Made changes as per code review feedback

SignalR#2258
YakhontovYaroslav · Jul 15, 2013 · 47cae6d · 47cae6d
1 parent 6baab2e
commit 47cae6d
Show file tree

Hide file tree

Showing 15 changed files with 21 additions and 24 deletions.
diff --git a/Microsoft.AspNet.SignalR.sln b/Microsoft.AspNet.SignalR.sln
@@ -15,6 +15,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "build", "build", "{1E4BA77C
 		build\Microsoft.AspNet.SignalR.OpenCover.xunit = build\Microsoft.AspNet.SignalR.OpenCover.xunit
 		src\Common\Microsoft.AspNet.SignalR.ruleset = src\Common\Microsoft.AspNet.SignalR.ruleset
 		src\Common\Microsoft.AspNet.SignalR.targets = src\Common\Microsoft.AspNet.SignalR.targets
+		build\Microsoft.AspNet.SignalR.UnitTests.OpenCover.xunit = build\Microsoft.AspNet.SignalR.UnitTests.OpenCover.xunit
 		Build\Microsoft.AspNet.SignalR.versions.targets = Build\Microsoft.AspNet.SignalR.versions.targets
 		ReleaseNotes.md = ReleaseNotes.md
 	EndProjectSection
@@ -92,7 +93,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNet.SignalR.Cl
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNet.SignalR.Tests", "tests\Microsoft.AspNet.SignalR.Tests\Microsoft.AspNet.SignalR.Tests.csproj", "{FBA09237-84CC-4383-BD12-CDF58E4020E8}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNet.SignalR.Client.CSharp.Tests", "tests\Microsoft.AspNet.SignalR.Client.CSharp.Tests\Microsoft.AspNet.SignalR.Client.CSharp.Tests.csproj", "{8B9D292A-0F2D-444D-9A61-2D96A0E7041E}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNet.SignalR.Client.Tests", "tests\Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.csproj", "{8B9D292A-0F2D-444D-9A61-2D96A0E7041E}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution

diff --git a/build/Build.proj b/build/Build.proj
@@ -162,7 +162,7 @@
 
   <ItemGroup>
     <UnitTestProjects Include="$(ProjectRoot)\tests\Microsoft.AspNet.SignalR.Tests\Microsoft.AspNet.SignalR.Tests.csproj"></UnitTestProjects>
-    <UnitTestProjects Include="$(ProjectRoot)\tests\Microsoft.AspNet.SignalR.Client.CSharp.Tests\Microsoft.AspNet.SignalR.Client.CSharp.Tests.csproj"></UnitTestProjects>
+    <UnitTestProjects Include="$(ProjectRoot)\tests\Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.csproj"></UnitTestProjects>
     <UnitTestProjects Include="$(ProjectRoot)\tests\Microsoft.AspNet.SignalR.SqlServer.Tests\Microsoft.AspNet.SignalR.SqlServer.Tests.csproj"></UnitTestProjects>
   </ItemGroup>
 
@@ -259,8 +259,8 @@
            Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.Tests.XunitResults.xml"
            Verbose="true" />
 
-    <xunit Assembly="$(ProjectArtifactsDir)\Microsoft.AspNet.SignalR.Client.CSharp.Tests\Microsoft.AspNet.SignalR.Client.CSharp.Tests.dll"
-       Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.Client.CSharp.Tests.XunitResults.xml"
+    <xunit Assembly="$(ProjectArtifactsDir)\Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.dll"
+       Xml="$(TestResultsPath)\Microsoft.AspNet.SignalR.Client.Tests.XunitResults.xml"
        Verbose="true" />
 
     <xunit Assembly="$(ProjectArtifactsDir)\Microsoft.AspNet.SignalR.SqlServer.Tests\Microsoft.AspNet.SignalR.SqlServer.Tests.dll"

diff --git a/build/Microsoft.AspNet.SignalR.OpenCover.targets b/build/Microsoft.AspNet.SignalR.OpenCover.targets
@@ -18,7 +18,7 @@
                MergeByHash="True"
                Filter="+[Microsoft.AspNet.SignalR*]*
                        -[Microsoft.AspNet.SignalR.Tests*]*
-                       -[Microsoft.AspNet.SignalR.CSharp.Tests*]*
+                       -[Microsoft.AspNet.SignalR.Client.Tests*]*
                        -[Microsoft.AspNet.SignalR.FunctionalTests*]*
                        -[Microsoft.AspNet.SignalR.Hosting.Memory*]*
                        -[Microsoft.AspNet.SignalR.TaskAsyncHelper]*"

diff --git a/build/Microsoft.AspNet.SignalR.OpenCover.xunit b/build/Microsoft.AspNet.SignalR.OpenCover.xunit
@@ -3,7 +3,7 @@
   <assemblies>
     <!-- NOTE: OpenCover requires shadow-copy to be false -->
     <assembly filename="Microsoft.AspNet.SignalR.Tests\Microsoft.AspNet.SignalR.Tests.dll" shadow-copy="false" />
-    <assembly filename="Microsoft.AspNet.SignalR.Client.CSharp.Tests\Microsoft.AspNet.SignalR.Client.CSharp.Tests.dll" shadow-copy="false" />
+    <assembly filename="Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.dll" shadow-copy="false" />
     <assembly filename="Microsoft.AspNet.SignalR.FunctionalTests\bin\Microsoft.AspNet.SignalR.FunctionalTests.dll" shadow-copy="false" />
   </assemblies>
 </xunit>
diff --git a/build/Microsoft.AspNet.SignalR.UnitTests.OpenCover.xunit b/build/Microsoft.AspNet.SignalR.UnitTests.OpenCover.xunit
@@ -3,6 +3,6 @@
   <assemblies>
     <!-- NOTE: OpenCover requires shadow-copy to be false -->
     <assembly filename="Microsoft.AspNet.SignalR.Tests\Microsoft.AspNet.SignalR.Tests.dll" shadow-copy="false" />
-    <assembly filename="Microsoft.AspNet.SignalR.Client.CSharp.Tests\Microsoft.AspNet.SignalR.Client.CSharp.Tests.dll" shadow-copy="false" />
+    <assembly filename="Microsoft.AspNet.SignalR.Client.Tests\Microsoft.AspNet.SignalR.Client.Tests.dll" shadow-copy="false" />
   </assemblies>
 </xunit>
diff --git a/src/Microsoft.AspNet.SignalR.Client45/Properties/AssemblyInfo.cs b/src/Microsoft.AspNet.SignalR.Client45/Properties/AssemblyInfo.cs
@@ -6,5 +6,5 @@
 [assembly: AssemblyTitle("Microsoft.AspNet.SignalR.Client45")]
 [assembly: AssemblyDescription(".NET client for SignalR")]
 
-[assembly: InternalsVisibleTo("Microsoft.AspNet.SignalR.Client.CSharp.Tests")]
+[assembly: InternalsVisibleTo("Microsoft.AspNet.SignalR.Client.Tests")]
 
diff --git a/...R.Client.CSharp.Tests/ChunkBufferFacts.cs → ....SignalR.Client.Tests/ChunkBufferFacts.cs b/...R.Client.CSharp.Tests/ChunkBufferFacts.cs → ....SignalR.Client.Tests/ChunkBufferFacts.cs
@@ -2,7 +2,7 @@
 using Microsoft.AspNet.SignalR.Client.Transports.ServerSentEvents;
 using Xunit;
 
-namespace Microsoft.AspNet.SignalR.CSharp.Tests
+namespace Microsoft.AspNet.SignalR.Client.Tests
 {
     public class ChunkBufferFacts
     {

diff --git a/...nt.CSharp.Tests/Client/ConnectionFacts.cs → ...lR.Client.Tests/Client/ConnectionFacts.cs b/...nt.CSharp.Tests/Client/ConnectionFacts.cs → ...lR.Client.Tests/Client/ConnectionFacts.cs
@@ -13,29 +13,25 @@
 using Xunit;
 using Xunit.Extensions;
 
-namespace Microsoft.AspNet.SignalR.CSharp.Tests
+namespace Microsoft.AspNet.SignalR.Client.Tests
 {
     public class ConnectionFacts : IDisposable
     {
         [Theory]
-        [InlineData("?clientProtocol=","")]
+        [InlineData("?clientProtocol=", "")]
         [InlineData("&clientProtocol=", "foo=bar")]
         public void NegotiatePassesClientProtocolCorrectly(string clientProtocolParameter, string connectionQueryString)
         {
             var connection = new Client.Connection("http://test", connectionQueryString);
 
-            Console.BackgroundColor = ConsoleColor.DarkCyan;
-            Console.WriteLine("*********************************");
-            Console.ResetColor();
-
             try
             {
                 connection.Start(new LongPollingTransport(new UrlInspectingHttpClient((url) =>
                 {
                     Assert.True(url.Contains(clientProtocolParameter + connection.Protocol.ToString()));
                 }))).Wait();
             }
-            catch 
+            catch
             {
                 // Swallow exceptions because the custom http client that we pass will throw unimplemented exceptions.
             }

diff --git a/...ient.CSharp.Tests/Client/HubProxyFacts.cs → ...nalR.Client.Tests/Client/HubProxyFacts.cs b/...ient.CSharp.Tests/Client/HubProxyFacts.cs → ...nalR.Client.Tests/Client/HubProxyFacts.cs
@@ -8,7 +8,7 @@
 using Newtonsoft.Json.Linq;
 using Xunit;
 
-namespace Microsoft.AspNet.SignalR.CSharp.Tests
+namespace Microsoft.AspNet.SignalR.Client.Tests
 {
     public class HubProxyFacts
     {

diff --git a/...ent.CSharp.Tests/Client/KeepAliveFacts.cs → ...alR.Client.Tests/Client/KeepAliveFacts.cs b/...ent.CSharp.Tests/Client/KeepAliveFacts.cs → ...alR.Client.Tests/Client/KeepAliveFacts.cs
@@ -6,7 +6,7 @@
 using Moq;
 using Xunit;
 
-namespace Microsoft.AspNet.SignalR.CSharp.Tests
+namespace Microsoft.AspNet.SignalR.Client.Tests
 {
     public class KeepAliveFacts
     {

diff --git a/...ent.CSharp.Tests/Client/TransportFacts.cs → ...alR.Client.Tests/Client/TransportFacts.cs b/...ent.CSharp.Tests/Client/TransportFacts.cs → ...alR.Client.Tests/Client/TransportFacts.cs
@@ -11,7 +11,7 @@
 using Xunit;
 using Xunit.Extensions;
 
-namespace Microsoft.AspNet.SignalR.CSharp.Tests
+namespace Microsoft.AspNet.SignalR.Client.Tests
 {
     public class TransportFacts
     {

diff --git a/...arp.Tests/EventSourceStreamReaderFacts.cs → ...ent.Tests/EventSourceStreamReaderFacts.cs b/...arp.Tests/EventSourceStreamReaderFacts.cs → ...ent.Tests/EventSourceStreamReaderFacts.cs
@@ -7,7 +7,7 @@
 using Moq;
 using Xunit;
 
-namespace Microsoft.AspNet.SignalR.CSharp.Tests
+namespace Microsoft.AspNet.SignalR.Client.Tests
 {
     public class EventSourceStreamReaderFacts : IDisposable
     {

diff --git a/...AspNet.SignalR.Client.CSharp.Tests.csproj → ...rosoft.AspNet.SignalR.Client.Tests.csproj b/...AspNet.SignalR.Client.CSharp.Tests.csproj → ...rosoft.AspNet.SignalR.Client.Tests.csproj
@@ -7,8 +7,8 @@
     <ProjectGuid>{8B9D292A-0F2D-444D-9A61-2D96A0E7041E}</ProjectGuid>
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
-    <RootNamespace>Microsoft.AspNet.SignalR.Client.CSharp.Tests</RootNamespace>
-    <AssemblyName>Microsoft.AspNet.SignalR.Client.CSharp.Tests</AssemblyName>
+    <RootNamespace>Microsoft.AspNet.SignalR.Client.Tests</RootNamespace>
+    <AssemblyName>Microsoft.AspNet.SignalR.Client.Tests</AssemblyName>
     <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
     <FileAlignment>512</FileAlignment>
     <SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>

diff --git a/...t.CSharp.Tests/Properties/AssemblyInfo.cs → ...R.Client.Tests/Properties/AssemblyInfo.cs b/...t.CSharp.Tests/Properties/AssemblyInfo.cs → ...R.Client.Tests/Properties/AssemblyInfo.cs
@@ -5,11 +5,11 @@
 // General Information about an assembly is controlled through the following 
 // set of attributes. Change these attribute values to modify the information
 // associated with an assembly.
-[assembly: AssemblyTitle("Microsoft.AspNet.SignalR.Client.CSharp.Tests")]
+[assembly: AssemblyTitle("Microsoft.AspNet.SignalR.Client.Tests")]
 [assembly: AssemblyDescription("")]
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("")]
-[assembly: AssemblyProduct("Microsoft.AspNet.SignalR.Client.CSharp.Tests")]
+[assembly: AssemblyProduct("Microsoft.AspNet.SignalR.Client.Tests")]
 [assembly: AssemblyCopyright("Copyright ©  2013")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]

diff --git a/...gnalR.Client.CSharp.Tests/packages.config → ...pNet.SignalR.Client.Tests/packages.config b/...gnalR.Client.CSharp.Tests/packages.config → ...pNet.SignalR.Client.Tests/packages.config