Repository navigation
fix: restore resetAssistantTextPresentation contract in coding-agent CI #5326
Description
Activity
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256GJC issue ownership v1
Issue: #5326
Owner: Yeachan-Heo / gaebal-gajae
Failing dev: ed67422
First parent: 26ac498
Required run: 34001273527
Dedicated branch: fix/issue-5326-assistant-presentation
Dedicated worktree: /home/bellman/Workspace/gc-dev-ci-33945756253
Scope: reproduce resetAssistantTextPresentation contract failures, inspect overlap, implement only the smallest owning-contract fix if not already owned, verify affected suites/package gates, and drive one dev PR to terminal resolution.
Exclusions: all other issues and PR implementations; main, release, tag, publish, global profile/config, persistent schedule.
-----BEGIN PGP SIGNATURE-----iHUEARYIAB0WIQQE16ZuzjuAE7BguBSIF/QUP4T15wUCapzDZQAKCRCIF/QUP4T1
50DXAQD8QHuh6MvWj2YqamYonSi98VAhubV8/ST/CIBpkzg26gEAgVjvhQnaGxa9
e3f4dNcqhmRPvwwTXBmPXhuxo9KjYAA=
=Xlrl
-----END PGP SIGNATURE-----—
[repo owner's gaebal-gajae (clawdbot) 🦞]-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256GJC issue #5326 findings v1
Failing dev: ed67422
Control parent: 26ac498
Control result: both exact revisions fail the seven affected suites with 30 occurrences of resetAssistantTextPresentation is not a function; packages/coding-agent source and tests are byte-identical across the PR #5317 merge. PR #5317 exposed, but did not introduce, this failure.
Classification: incomplete test-double contract. Production InteractiveMode implements the required resetAssistantTextPresentation callback and production callers correctly invoke it unconditionally at transcript/session identity boundaries. Seven fixtures cast incomplete objects through unknown.
Overlap: PR #5323 independently owns resume-session-reentrancy.test.ts commit 5cc279d; this fix excludes that file. PRs #5313, #5283, and #5321 do not repair the seven affected fixtures.
Owned fix: signed commit 34f9845 updates exactly seven implicated fixtures and adds reset ownership assertions; no optional chaining, no no-op production fallback, no skipped or weakened tests.
Verification: 56 tests across seven files pass; 20 repeated passes completed; coding-agent package check and package build pass.
Separate failures from run 34001273527: mcp-lifecycle-cleanup.test.ts still times out locally and gjc-plugin-runtime-adapters.test.ts still has two plugin read-count failures. They are distinct from the missing presentation-reset fixture contract and are not implemented under issue #5326.
-----BEGIN PGP SIGNATURE-----iHUEARYIAB0WIQQE16ZuzjuAE7BguBSIF/QUP4T15wUCapzF8AAKCRCIF/QUP4T1
58JSAQD5NflkS85EQiF0maPgsAExUJJmwHFS+h0LSZQa6RDeFQEA4oe05+dyt4WK
1MrPg1lICuonhXwrLMdUIuNWpiS4+gQ=
=n9mM
-----END PGP SIGNATURE-----—
[repo owner's gaebal-gajae (clawdbot) 🦞]- added a commit that references this issue
on Sep 6, 2026 Resolved by merged dev PR #5327.
Exact tuple:
- base:
ed67422699299b0257dd45ec1d37167b474b4918 - fix head:
34f9845278a47599340581f05f6e193029ae082a - merge:
c10db31866eb84efc7b420cf2f45d319195d52f4 - merged at:
2026-09-06T01:57:32Z
The repair remains limited to the seven incomplete presentation-reset fixtures. PR #5323-owned
resume-session-reentrancy.test.ts, the independently reproduced MCP lifecycle timeout, and plugin-adapter read-count failures were not bundled.—
[repo owner's gaebal-gajae (clawdbot) 🦞]- base:
Observed failure
Exact dev
ed67422699299b0257dd45ec1d37167b474b4918fails required Dev CI run https://github.com/Yeachan-Heo/gajae-code/actions/runs/34001273527 . Multiple coding-agent test paths throwresetAssistantTextPresentation is not a function.Published failure classification: #5317 (comment)
Affected jobs include shard 3 (
101401272683, /new and /drop replacement), shard 5 (101401272661, InteractiveMode.showStatus), shard 6 (101401272641, controllers/lifecycle), shard 7 (101401272666, deferred-shell/session deletion), and shard 8 (101401272648, plugin/runtime). Aggregator failures are consequences, not additional root-cause issues.Scope and verification
Reproduce on the exact failing dev and its first parent
26ac49874df6001cb57e8a3296a8ddece43c8c8c; determine whether the missing contract is in runtime code or incomplete test doubles. Repair the owning contract and all directly affected callsites/fixtures without skipping tests, weakening assertions, or broad optional-call fallbacks. Classify any remaining distinct failures separately.PR #5317 changed only packages/tui; this does not by itself prove the coding-agent failures predate it. Preserve first-parent/control evidence. Search found no open issue for the missing method; #5323/#5313/#5283 appeared in broad PR search but their current bodies and recent comments did not establish repair ownership for this exact run/signature. Recheck overlap before any implementation.
Acceptance: affected targeted suites and exact required coding-agent CI pass, with current-head review and a dev-target fix PR. Investigation/implementation is not yet confirmed; this issue records the concrete unassigned repair gap, not a completed fix.
—
[repo owner's gaebal-gajae (clawdbot) 🦞]