Repository navigation
Build the examples against local YAMS sources instead of the YAMS vendordeps - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples now compile YAMS from its
yams/javasources, as they already do for YAGSL'syagsl/java, instead of the published YAMS vendordeps. A YAGSL change can then be built and tested against an unreleased YAMS change.examples/commands2/vendordeps/yams_commands2.jsonandexamples/commands3/vendordeps/yams_commands3.jsonare removed.build.gradle: theYAGSL_TESTINGblock compiles../../../YAMS/yams/java, a YAMS checkout beside this repository, as before, and now also../../YAMS/yams/java, a checkout inside it. A source folder that doesn't exist is skipped.YAMS/before building each example.YAGSL_TESTINGblock is stripped, the publishedyams_commands2.jsonoryams_commands3.jsonis downloaded into each example'svendordeps/, so released examples still use the YAMS vendordep.The release builds against YAMS's default branch but ships the latest published YAMS vendordep. If YAMS's default branch has changes that aren't released yet, a released example could build in the release job and not against the published vendordep.
Tests: both examples compile against a local YAMS checkout.