Add --no-private-id-locs and new NEW_ID macro #5352
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option named
--no-private-id-locs
that prevents users of the new version ofNEW_ID
andNEW_ID_SUFFIX
from adding Yosys C++ source file locations to automatic design object names.The old macros still work the same way as before and now give a deprecation warning. The new macros are named
NEWER_ID
andNEWER_ID_SUFFIX
,NEW_ID2
andNEW_ID_SUFFIX2
are an option as well.#5315 benefits from this feature, reducing the proportion of PRs that require an update of the reference RTLIL dump for itsI'm removing that test to decouple things and reduce test maintenancesynth -noabc
result stability test. Sorry for the reviewer spam.