Fix Verific run-test.sh #5504
Open
Fix Verific run-test.sh #5504
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrystalDelusion
requested changes
Nov 25, 2025
| source ../gen-tests-makefile.sh | ||
| generate_mk --yosys-scripts --bash | ||
| sed -i '1i\export ASAN_OPTIONS=halt_on_error=0' run-test.mk | ||
| echo "$(echo 'export ASAN_OPTIONS=halt_on_error=0'; cat run-test.mk)" > run-test.mk |
Member
There was a problem hiding this comment.
This shouldn't remove the newline at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
sed -iwith a more portable approach for prepending the ASAN_OPTIONS export to run-test.mk.The sed approach with
1idoesn't work reliably on all systems. This uses echo instead, which is more straightforward and works everywhere.Test suite runs correctly with this change. This is an infrastructure fix with no new tests. To evaluate run existing test suite.