Skip to content

Upgrade to v2.8.2 + Use the prebuilt package provided upstream#14

Merged
ericgaspar merged 6 commits intotestingfrom
prebuilt_package
Apr 5, 2026
Merged

Upgrade to v2.8.2 + Use the prebuilt package provided upstream#14
ericgaspar merged 6 commits intotestingfrom
prebuilt_package

Conversation

@oleole39
Copy link
Copy Markdown
Contributor

@oleole39 oleole39 commented Feb 16, 2026

Install upstream prebuilt package instead of having the YNH instance building from source.

  • Pros: faster to install, and all hardware will afford hosting it
  • Cons: less customization options (or we should use workflows as in https://github.com/oleole39/prebuild-app), no control on build process.

There are still some issues:

  • bad links in tools.html which would make a better index page than the default home page, cf. (Bug) Wrong paths in tools.html alam00000/bentopdf#483. Before this is fixed you can go to index.html where the links to the tools work fine.
    • not an issue in "simple mode" or/and v2.8.2
  • Workers fail to load PDFs in some tools, e.g. compare-pdfs.html. Not sure whether this is due to Nginx configuration or the build itself (it is working as expected on the official instance).
  • App is contacting Github API to get stars count... A kind of telemetry that should ideally be removed.
    • not an issue in "simple mode" or/and v2.8.2
  • WASM ressources (cf. wasm-settings.html) are loaded from jsdelivr.net CDN. Ideally they should be locally hosted. One way to proceed is to treat dependencies as such: https://github.com/YunoHost-Apps/jsoncrack_ynh/blob/db43e6c8d91706393fab1335b88902fc3490109e/manifest.toml#L62 even though jsdelivr.net is not currently supported by the autoupdate script.
    • not an issue in "simple mode" or/and v2.8.2
  • keep optional config.json during upgrade

CC: @ericgaspar, @Klodd

Comment thread conf/nginx.conf
Co-authored-by: Klodd
@oleole39
Copy link
Copy Markdown
Contributor Author

oleole39 commented Feb 20, 2026

Next upstream release should offer a "simple mode" version (the tools without the branded website) which would better suit this YNH package: alam00000/bentopdf#484 (comment).
Todo when available:

  • Update asset regex in manifest
  • set index.html again as index page in nginx.conf

@Thovi98
Copy link
Copy Markdown
Member

Thovi98 commented Mar 11, 2026

So maybe latest update will help you? #22

In the meantime I guess we can merge the testong branch?

@oleole39
Copy link
Copy Markdown
Contributor Author

oleole39 commented Mar 11, 2026

So maybe latest update will help you? #22

The simple mode version is not available yet as built archive file in releases. This PR may help but has not been reviewed yet: alam00000/bentopdf#560

In the meantime I guess we can merge the testong branch?

Probably but I can't test on my side due to the demanding npm build process, so I didn't merge anything.

@ericgaspar
Copy link
Copy Markdown
Member

!testme

@yunohost-bot
Copy link
Copy Markdown
Contributor

Alrighty!
Test Badge

@ericgaspar
Copy link
Copy Markdown
Member

lets wait for alam00000/bentopdf#560 to be merged

@oleole39
Copy link
Copy Markdown
Contributor Author

oleole39 commented Apr 5, 2026

!testme

@yunohost-bot
Copy link
Copy Markdown
Contributor

Fingers crossed!
Test Badge

@oleole39 oleole39 changed the title Use the prebuilt package provided upstream Upgrade to v2.8.2 + Use the prebuilt package provided upstream Apr 5, 2026
@oleole39
Copy link
Copy Markdown
Contributor Author

oleole39 commented Apr 5, 2026

@ericgaspar @Thovi98

Manually tested, I guess this can be merged but i'll let you review as I believe you've better followed the commit history for this app than me.

@ericgaspar ericgaspar merged commit 6cdc842 into testing Apr 5, 2026
1 check passed
@ericgaspar ericgaspar deleted the prebuilt_package branch April 5, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants