Upgrade to v2.8.2 + Use the prebuilt package provided upstream#14
Upgrade to v2.8.2 + Use the prebuilt package provided upstream#14ericgaspar merged 6 commits intotestingfrom
Conversation
3452044 to
68a5b3f
Compare
Co-authored-by: Klodd
|
Next upstream release should offer a "simple mode" version (the tools without the branded website) which would better suit this YNH package: alam00000/bentopdf#484 (comment).
|
|
So maybe latest update will help you? #22 In the meantime I guess we can merge the testong branch? |
The simple mode version is not available yet as built archive file in releases. This PR may help but has not been reviewed yet: alam00000/bentopdf#560
Probably but I can't test on my side due to the demanding npm build process, so I didn't merge anything. |
|
!testme |
|
lets wait for alam00000/bentopdf#560 to be merged |
|
!testme |
|
Manually tested, I guess this can be merged but i'll let you review as I believe you've better followed the commit history for this app than me. |


Install upstream prebuilt package instead of having the YNH instance building from source.
There are still some issues:
tools.htmlwhich would make a better index page than the default home page, cf. (Bug) Wrong paths in tools.html alam00000/bentopdf#483. Before this is fixed you can go to index.html where the links to the tools work fine.compare-pdfs.html. Not sure whether this is due to Nginx configuration or the build itself (it is working as expected on the official instance).wasm-settings.html) are loaded from jsdelivr.net CDN. Ideally they should be locally hosted. One way to proceed is to treat dependencies as such: https://github.com/YunoHost-Apps/jsoncrack_ynh/blob/db43e6c8d91706393fab1335b88902fc3490109e/manifest.toml#L62 even though jsdelivr.net is not currently supported by the autoupdate script.CC: @ericgaspar, @Klodd