Update PHP to version 8.5#628
Open
CodeShakingSheep wants to merge 1 commit into
Open
Conversation
|
Thanks did you test the SSO with php8.5 ? |
Member
Author
|
I haven't tested SSO on my server but the PHP script is pretty straight forward and I don't see anything in there that could break with PHP 8.5. |
|
Thanks I know that following the complexity of this script there are no huge risk that something break. But from my experience we had in the past many time something which break around this and it took a long time to discover this because it's not something that we test everyday. Also php8.4 is still supported for a long time and in long term this script will be removed and replaced by OIDC. So following this I don't really see the advantage to upgrade the php version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow up of #601 to update PHP to its latest stable version.
Solution
Update PHP to version 8.5.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)