Skip to content

WIP: App domain resource#2099

Draft
Josue-T wants to merge 2 commits into
devfrom
app_domain_resource
Draft

WIP: App domain resource#2099
Josue-T wants to merge 2 commits into
devfrom
app_domain_resource

Conversation

@Josue-T

@Josue-T Josue-T commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

The problem

YunoHost/issues#2563

Solution

Implement the feature

PR Status

In draft

How to test

A test app was made with cryptpad and with the MAS branch of synapse with postgresql

Comment thread src/utils/resources.py Fixed
Comment thread src/utils/resources.py Fixed
@Josue-T
Josue-T force-pushed the app_domain_resource branch from c61c20b to f266290 Compare April 26, 2025 23:28
@zamentur

zamentur commented Jun 6, 2025

Copy link
Copy Markdown
Member

Should it be a domain question ? in order to customize the second extra domains ???

Some apps are not web app, so may be we should declare the main domain as a ressources too ? (don't remeber how are declared the non webapp)

@Josue-T

Josue-T commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

Should it be a domain question ? in order to customise the second extra domains ???

Initially I didn't have the idea to provide the possibility to customise the extra domain. Maybe it could be useful in some case but I also think that maybe in same case we might need to have the possibility to have a static value, so the user can't customise. By example for XMPP I'm not sure that it's possible to customise the extra domains.

Some apps are not web app, so may be we should declare the main domain as a ressources too ?

Yes it's also a possibility to have also the main domain as resource but currently it seem that a resource is defined only by the packager and can't be modified, while the domain is something that can selected at the install time.

(don't remeber how are declared the non webapp)

I think the app like this just don't ask for a domain at install time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants