Restore stable quantifier benchmark behavior - #10665
Open
Nikolaj Bjorner (NikolajBjorner) wants to merge 2 commits into
Open
Restore stable quantifier benchmark behavior#10665Nikolaj Bjorner (NikolajBjorner) wants to merge 2 commits into
Nikolaj Bjorner (NikolajBjorner) wants to merge 2 commits into
Conversation
Add an opt-in legacy nested-binder pattern inference mode and restore the previous hash combiner to avoid order-sensitive solver regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The projection test specifically required the rejected combine_hash implementation to outperform the restored combiner. Keep the functional chained-hashtable coverage while removing that incompatible A/B guard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pi.legacy_nested_bindersmode that reproduces pre-c56b2cbaanested-binder candidate handlingcombine_hashimplementation to avoid hash-order-sensitive solver regressionsRegression analysis
Chronological replay from
965db51b5identifiedc56b2cbaaandaa6dddbdfas transient pattern-inference regressions;7c8c6a4dflater superseded those changes and restored the useful patterns.82a0d4297introduced the persistent regression by changing hash-table/search ordering.With regression-causing changes reverted, the Release replay endpoint solves issue #10645 in a 3.17s median. On the current Debug build, the benchmark now returns
unsatin 39.7s instead of timing out after 60s.Validation
unsat