Skip to content

Conversation

@cloudbells
Copy link
Collaborator

PLAYER_DEAD fires twice for players with a pet. Added a simple check so that code only runs once per death in PLAYER_DEAD.

@cloudbells cloudbells linked an issue Dec 2, 2021 that may be closed by this pull request
@aaronma37
Copy link
Collaborator

There seems to be two type of guild messages sent out, one correct one and one with the pets name in it. Do we know if the pet one always comes second? Otherwise we might be letting the wrong one show with this

@cloudbells
Copy link
Collaborator Author

cloudbells commented Dec 2, 2021

Good point. The death source is from the combat log, and since the last message seems to include the pet name as the source of death, I'm assuming the game just assigns the pet itself to be the source of its "death". That would need further testing for sure, but from my limited testing it was always player first and then pet second. Worst case, we can always just check what the Last_Attack_Source was:

if Last_Attack_Source == PET_NAME then return end

- Now only checking CLEU events that target the player.
- Replaced name check with GUID check in CLEU.
- If the pet name is the last damage source on the player, PLAYER_DEAD will now do nothing.
@cloudbells
Copy link
Collaborator Author

There seems to be two type of guild messages sent out, one correct one and one with the pets name in it. Do we know if the pet one always comes second? Otherwise we might be letting the wrong one show with this

Should be fixed now. I've tested it 20+ times on my Hunter (not on any Warlock) and it has worked as expected each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra Erroneous Death Annoucements to Guild Chat

2 participants