-
Notifications
You must be signed in to change notification settings - Fork 12
PES-2943: refactor třídy WcLogger #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zemekoule
merged 6 commits into
pre-release
from
PES-2943-prerelease_refactor-wc-logger-class
Jan 8, 2026
Merged
PES-2943: refactor třídy WcLogger #908
zemekoule
merged 6 commits into
pre-release
from
PES-2943-prerelease_refactor-wc-logger-class
Jan 8, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Code Coverage Report |
7ca15f7 to
d995430
Compare
- Move from Packetery\Module to Packetery\Module\Log namespace - Rename class to ArgumentTypeErrorLogger for single-purpose clarity - Make methods non-static with WcAdapter and WpAdapter injected via constructor - Rename logArgumentTypeError() to log() and inline original log() method - Keep write() method as private helper - Use WpAdapter for didAction() and addAction() calls instead of direct WordPress functions - Update all usages across codebase (10 files) - Add comprehensive unit tests with full coverage - Modernize code with PHP 7.4+ typed properties - Add complete PHPDoc documentation
d995430 to
e35a858
Compare
- Remove Logger::formatMessage call (message is always string) - Remove $level parameter from write() method, use constant directly - Remove PHPDoc from BulkActions constructor - Type properties and remove PHPDoc comments in Checkout class - Update tests to use string arguments for realistic error scenarios
- Update composer/composer from ^2.6 to ^2.9.3 - Fixes CVE-2025-67746 (ANSI sequence injection vulnerability)
jan-potuznik-z
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.