Palette: Add keyboard shortcuts & mnemonics to Project Export UI - #127
Palette: Add keyboard shortcuts & mnemonics to Project Export UI#127Zee2401 wants to merge 4 commits into
Conversation
- Added mnemonics to Save (Alt+S) and Cancel (Alt+C) buttons via underline=0. - Bound Alt+S, Alt+C, and Escape key events to action handlers on MainWindow. - Configured WM_DELETE_WINDOW protocol to handle window manager close actions cleanly. - Added headless unit test coverage for MainWindow keyboard bindings. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Added mnemonics to Save (Alt+S) and Cancel (Alt+C) buttons via underline=0. - Bound Alt+S, Alt+C, and Escape key events to action handlers on MainWindow. - Configured WM_DELETE_WINDOW protocol to handle window manager close actions cleanly. - Added headless unit test coverage for MainWindow keyboard bindings. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
- Added mnemonics to Save (Alt+S) and Cancel (Alt+C) buttons via underline=0. - Bound Alt+S, Alt+C, and Escape key events to action handlers on MainWindow. - Configured WM_DELETE_WINDOW protocol to handle window manager close actions cleanly. - Added headless unit test coverage for MainWindow keyboard bindings. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
- Added mnemonics to Save (Alt+S) and Cancel (Alt+C) buttons via underline=0. - Bound Alt+S, Alt+C, and Escape key events to action handlers on MainWindow. - Configured WM_DELETE_WINDOW protocol to handle window manager close actions cleanly. - Added headless unit test coverage for MainWindow keyboard bindings. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
1 participant
🎨 Palette: Keyboard Navigation & Protocol Handling for Project Export UI
💡 What
underline=0) for the "Save" (Alt+S) and "Cancel" (Alt+C) action buttons inscripts/o3de/o3de/ui/export_project.py.<Alt-s>,<Alt-S>,<Alt-c>,<Alt-C>,<Escape>) to their respective handlers (on_okandon_cancel).WM_DELETE_WINDOWprotocol binding to cleanly invokeon_cancelwhen the user closes the dialog via window manager decorations (e.g. clicking 'X' or pressing Alt+F4).scripts/o3de/tests/test_export_project_ui.pyto headlessly verify binding behavior.🎯 Why
Improves keyboard accessibility and window interaction UX for desktop users of the Project Export settings tool.
♿ Accessibility
Provides full keyboard-only navigation for saving and canceling project export settings as well as standard modal dialog dismissal via Escape or window close.
PR created automatically by Jules for task 15814890924639844272 started by @Zee2401