Skip to content

🎨 Palette: Standardize search inputs in LyShine Animation Editor#27

Open
Zee2401 wants to merge 1 commit into
developmentfrom
palette/lyshine-search-ux-16295357437988763774
Open

🎨 Palette: Standardize search inputs in LyShine Animation Editor#27
Zee2401 wants to merge 1 commit into
developmentfrom
palette/lyshine-search-ux-16295357437988763774

Conversation

@Zee2401

@Zee2401 Zee2401 commented May 19, 2026

Copy link
Copy Markdown
Owner

This PR implements a micro-UX improvement in the LyShine Gem by standardizing the search inputs in the Animation Editor.

Specifically:

  • In UiAnimViewFindDlg.ui and UiAnimViewNodes.ui, the search/filter inputs were promoted from QLineEdit to AzQtComponents::SearchLineEdit.
  • placeholderText set to "Search..." for immediate visual context.
  • clearButtonEnabled set to true to allow users to quickly reset filters.
  • accessibleName set to "Search" to ensure screen readers identify the field's purpose.

These changes align with the O3DE standard for search interfaces and improve both usability and accessibility with zero risk of logic regressions.


PR created automatically by Jules for task 16295357437988763774 started by @Zee2401

Summary by CodeRabbit

New Features

  • Upgraded search fields in Animation Editor dialogs with improved usability and efficiency features. Search fields now display helpful placeholder text ("Search...") to guide users during searches, and include dedicated quick-clear buttons for instant text removal. These interface enhancements make animation filtering, searching, and content organization operations more streamlined and user-friendly.

Review Change Stack

Upgraded standard QLineEdit search fields in LyShine's Animation Find dialog and Nodes view to AzQtComponents::SearchLineEdit.

Improvements:
- Enabled built-in clear button for better usability.
- Added localized "Search..." placeholder text.
- Added "Search" accessible name for improved screen reader support.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4ab449d4-624b-450f-8b2a-070dc3d969e2

📥 Commits

Reviewing files that changed from the base of the PR and between 876034b and 47e0e55.

📒 Files selected for processing (2)
  • Gems/LyShine/Code/Editor/Animation/UiAnimViewFindDlg.ui
  • Gems/LyShine/Code/Editor/Animation/UiAnimViewNodes.ui

📝 Walkthrough

Walkthrough

Two UI definition files for the LyShine editor animation system upgrade search and filter input controls from standard QLineEdit to AzQtComponents::SearchLineEdit, adding placeholder text, clear buttons, and accessibility labels for improved user interaction.

Changes

Search Input Widget Enhancement

Layer / File(s) Summary
UiAnimViewFindDlg search field upgrade
Gems/LyShine/Code/Editor/Animation/UiAnimViewFindDlg.ui
The FILTER widget changes from QLineEdit to AzQtComponents::SearchLineEdit. Properties are added: placeholderText ("Search..."), clearButtonEnabled (true), and accessibleName ("Search"). The <customwidgets> section registers AzQtComponents::SearchLineEdit with its base class and header path.
UiAnimViewNodes search field upgrade
Gems/LyShine/Code/Editor/Animation/UiAnimViewNodes.ui
The searchField widget changes from QLineEdit to AzQtComponents::SearchLineEdit with placeholderText ("Search…"), clearButtonEnabled (true), and accessibleName ("Search"). A corresponding <customwidget> registration for AzQtComponents::SearchLineEdit is added to the <customwidgets> section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Zee2401/o3de#2: Both PRs update editor filter/search inputs to use O3DE AzQtComponents-based search UI conventions (setting placeholderText, enabling the clear button, and applying AzQtComponents search styling via SearchLineEdit / applySearchStyle).
  • Zee2401/o3de#1: Both PRs update editor search/filter UI fields to use AzQtComponents-based line edit/search styling (adding placeholder text and clear-button behavior) in find/nodes dialogs, so the changes are in the same UX area and align at the code/UI control level.

Poem

🐰 SearchLineEdit hops in so bright,
Placeholders guide the seeker's sight,
Clear buttons pop like morning dew,
Two dialogs dressed in polished hue,
A-accessible for all to use!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers what the PR does with specific details, but lacks testing information required by the template. Add a 'How was this PR tested?' section to complete the required template structure.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: standardizing search inputs in the LyShine Animation Editor using a specific component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/lyshine-search-ux-16295357437988763774

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant