🎨 Palette: Standardize search inputs in Animation Editor#32
Conversation
This change promotes the search and filter inputs in the LyShine Animation Editor to use `AzQtComponents::SearchLineEdit`.
💡 What:
- Promoted `searchField` in `UiAnimViewNodes.ui` and `FILTER` in `UiAnimViewFindDlg.ui` to `AzQtComponents::SearchLineEdit`.
- Added standard `placeholderText` ("Search...").
- Enabled the built-in clear button (`clearButtonEnabled`).
- Added `accessibleName` ("Search") for improved screen reader support.
🎯 Why:
- Provides a consistent O3DE search look and feel (including the magnifying glass icon).
- Improves usability with an easy way to clear filters.
- Enhances accessibility for vision-impaired users.
♿ Accessibility:
- Added `accessibleName` to ensure screen readers identify the purpose of these input fields.
Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates guidance to prefer setting ChangesSearch input property standardization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This change implements micro-UX improvements for search and filter inputs in the LyShine Animation Editor using standard QLineEdit properties to ensure build compatibility and avoid CI timeouts.
💡 What:
- Added standard `placeholderText` ("Search...") to `searchField` in `UiAnimViewNodes.ui` and `FILTER` in `UiAnimViewFindDlg.ui`.
- Enabled the built-in clear button (`clearButtonEnabled`) for both fields.
- Added `accessibleName` ("Search") for improved screen reader support.
🎯 Why:
- Provides immediate visual context and a convenient way to clear filters.
- Enhances accessibility for vision-impaired users.
- Reverted the previous widget promotion to `AzQtComponents::SearchLineEdit` to avoid triggering full rebuilds and CI timeouts in the large LyShine Gem.
♿ Accessibility:
- Added `accessibleName` to ensure screen readers correctly identify the purpose of these input fields.
Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
1 participant
This PR standardizes search inputs in the LyShine Animation Editor by promoting them to
AzQtComponents::SearchLineEditand adding standard properties for usability and accessibility.PR created automatically by Jules for task 2172269837614038782 started by @Zee2401
Summary by CodeRabbit
Documentation
Improvements