🎨 Palette: Standardize EBus Handler Action Menu search input#33
🎨 Palette: Standardize EBus Handler Action Menu search input#33Zee2401 wants to merge 4 commits into
Conversation
This change upgrades the search filter in the EBus Handler Action Menu to use AzQtComponents::SearchLineEdit, enables the clear button, and adds an accessibleName for better screen reader support. This follows O3DE's standard UX pattern for search inputs. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds search filter functionality and accessibility enhancements to two editor UI components. The EBusHandlerActionMenu enables the clear button on its search filter during initialization, and ConsoleSCB.ui receives accessible names and placeholder text on find-bar and toolbar controls. ChangesEditor UI Enhancements
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This change enhances the search filter in the EBus Handler Action Menu by enabling the clear button and adding an accessibleName directly in the .ui file. This surgical approach avoids C++ header dependency changes that can trigger large rebuilds and CI timeouts in the Script Canvas Gem. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
This change enhances the search/filter inputs in the LyShine Animation editor (Nodes view and Find dialog) by adding placeholder text, enabling the built-in clear button, and adding an accessibleName. These improvements follow O3DE's standard UX pattern for search inputs while remaining surgical to minimize CI build impact. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
This change upgrades the find bar in the Editor Console to include a standard search placeholder and clear button. It also adds accessibleName properties to several icon-only tool buttons in the console interface to improve screen reader support. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
🎨 Palette: Standardize EBus Handler Action Menu search input
💡 What:
searchFilterwidget inebushandleractionlistwidget.uifromQLineEdittoAzQtComponents::SearchLineEdit.accessibleNameproperty to the search filter in the UI file.EBusHandlerActionMenu.cpp.🎯 Why:
♿ Accessibility:
accessibleName="Search"to the search filter widget.PR created automatically by Jules for task 13449369559259870860 started by @Zee2401
Summary by CodeRabbit