Skip to content

🎨 Palette: Standardize EBus Handler Action Menu search input#33

Open
Zee2401 wants to merge 4 commits into
developmentfrom
palette-standardize-ebus-search-13449369559259870860
Open

🎨 Palette: Standardize EBus Handler Action Menu search input#33
Zee2401 wants to merge 4 commits into
developmentfrom
palette-standardize-ebus-search-13449369559259870860

Conversation

@Zee2401

@Zee2401 Zee2401 commented May 25, 2026

Copy link
Copy Markdown
Owner

🎨 Palette: Standardize EBus Handler Action Menu search input

💡 What:

  • Promoted the searchFilter widget in ebushandleractionlistwidget.ui from QLineEdit to AzQtComponents::SearchLineEdit.
  • Added the accessibleName property to the search filter in the UI file.
  • Enabled the built-in clear button for the search filter in EBusHandlerActionMenu.cpp.

🎯 Why:

  • Improves visual consistency with other search inputs in the O3DE Editor.
  • Enhances usability by providing a quick way to clear the search text.
  • Improves accessibility for screen reader users by providing a descriptive name for the input field.

♿ Accessibility:

  • Added accessibleName="Search" to the search filter widget.

PR created automatically by Jules for task 13449369559259870860 started by @Zee2401

Summary by CodeRabbit

  • New Features
    • Enabled the search field clear button for improved usability
    • Added placeholder text and accessible names to console UI controls for enhanced accessibility

Review Change Stack

This change upgrades the search filter in the EBus Handler Action Menu
to use AzQtComponents::SearchLineEdit, enables the clear button, and
adds an accessibleName for better screen reader support. This follows
O3DE's standard UX pattern for search inputs.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented May 25, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ef9cc751-5e6a-4a92-b7d6-c1654f0899ed

📥 Commits

Reviewing files that changed from the base of the PR and between 96fe38c and 0b615dd.

📒 Files selected for processing (1)
  • Code/Editor/Controls/ConsoleSCB.ui
✅ Files skipped from review due to trivial changes (1)
  • Code/Editor/Controls/ConsoleSCB.ui

📝 Walkthrough

Walkthrough

This PR adds search filter functionality and accessibility enhancements to two editor UI components. The EBusHandlerActionMenu enables the clear button on its search filter during initialization, and ConsoleSCB.ui receives accessible names and placeholder text on find-bar and toolbar controls.

Changes

Editor UI Enhancements

Layer / File(s) Summary
EBusHandlerActionMenu search clear button
Gems/ScriptCanvas/Code/Editor/View/Windows/EBusHandlerActionMenu.cpp
Enables the clear ("x") button on the search filter widget during UI construction.
ConsoleSCB accessibility enhancements
Code/Editor/Controls/ConsoleSCB.ui
Find bar search field gains placeholder text, clear-button setting, and accessible name. Find-bar control buttons (previous, next, close) and console toolbar buttons (Console Type, Find in Console, Console Options) are assigned descriptive accessible names.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Zee2401/o3de#2: Both PRs update QLineEdit-based search/filter UI to enable the built-in clear ("x") button and related search-field UX improvements across different editor components.

Poem

🐰 The search bar clears with just a tap,
And buttons now tell what they're about,
Accessibility blooms without a gap,
EditorUI shines—no doubt! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions standardizing the EBus Handler Action Menu search input, which aligns with the main objective of promoting the searchFilter widget and adding accessibility features.
Description check ✅ Passed The description comprehensively covers what was changed (widget promotion, accessibleName addition, clear button enablement), why (consistency, usability, accessibility), and includes accessibility details, fulfilling the template requirements.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-standardize-ebus-search-13449369559259870860

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

google-labs-jules Bot and others added 3 commits May 25, 2026 23:44
This change enhances the search filter in the EBus Handler Action Menu
by enabling the clear button and adding an accessibleName directly
in the .ui file. This surgical approach avoids C++ header dependency
changes that can trigger large rebuilds and CI timeouts in the
Script Canvas Gem.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
This change enhances the search/filter inputs in the LyShine Animation
editor (Nodes view and Find dialog) by adding placeholder text,
enabling the built-in clear button, and adding an accessibleName.
These improvements follow O3DE's standard UX pattern for search
inputs while remaining surgical to minimize CI build impact.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
This change upgrades the find bar in the Editor Console to include
a standard search placeholder and clear button. It also adds
accessibleName properties to several icon-only tool buttons in the
console interface to improve screen reader support.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant