Skip to content

🎨 Palette: Standardize search field UX and accessibility#35

Open
Zee2401 wants to merge 1 commit into
developmentfrom
palette-search-ux-improvements-3317471535877970760
Open

🎨 Palette: Standardize search field UX and accessibility#35
Zee2401 wants to merge 1 commit into
developmentfrom
palette-search-ux-improvements-3317471535877970760

Conversation

@Zee2401

@Zee2401 Zee2401 commented May 27, 2026

Copy link
Copy Markdown
Owner

🎨 Palette: Improved search field usability and accessibility in the O3DE Editor.

💡 What:
Added standard search properties to QLineEdit widgets in three Editor UI files:

  • Gems/AudioSystem/Code/Source/Editor/AudioSystemPanel.ui
  • Gems/LyShine/Code/Editor/Animation/UiAnimViewFindDlg.ui
  • Gems/LyShine/Code/Editor/Animation/UiAnimViewNodes.ui

🎯 Why:
Standardizing search inputs improves consistency across the Editor. Specifically:

  • clearButtonEnabled: Allows users to quickly clear filters with one click.
  • accessibleName: Provides a clear label for screen readers (improving accessibility beyond just placeholder text).
  • placeholderText: Ensures "Search..." is used consistently as a prompt.

Accessibility:
Explicitly set accessibleName to "Search" on all modified fields to ensure they are properly identified by assistive technologies.

Verified XML syntax for all modified files.


PR created automatically by Jules for task 3317471535877970760 started by @Zee2401

Summary by CodeRabbit

  • Documentation

    • Updated development guidance for metadata-only UI file changes in large gems to avoid costly rebuild cycles.
  • Style

    • Enhanced search and filter fields across editor UI with improved placeholder text, clear button functionality, and accessibility attributes for better usability and accessibility.

Review Change Stack

…em and LyShine

This commit improves the search fields in the Audio System Panel and LyShine Animation views by:
- Enabling the clear button for faster search resets.
- Adding accessible names to ensure screen reader support.
- Standardizing placeholder text to "Search..." for better visual cues.

These changes are implemented as metadata-only additions to .ui files to ensure build safety in large Gems.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b13490fc-fee9-49c2-b4f7-0a6e72441dd2

📥 Commits

Reviewing files that changed from the base of the PR and between 876034b and 8ee2e73.

📒 Files selected for processing (4)
  • .Jules/palette.md
  • Gems/AudioSystem/Code/Source/Editor/AudioSystemPanel.ui
  • Gems/LyShine/Code/Editor/Animation/UiAnimViewFindDlg.ui
  • Gems/LyShine/Code/Editor/Animation/UiAnimViewNodes.ui

📝 Walkthrough

Walkthrough

The PR adds search field UX improvements across three O3DE gem editor panels by applying consistent metadata-only property updates to .ui files. A new guidance entry documents the approach to avoid expensive rebuild/cache invalidation.

Changes

Search Filter UX Improvements

Layer / File(s) Summary
Pattern guidance and rationale
.Jules/palette.md
New dated guidance (2025-05-22) recommends metadata-only .ui property changes for search styling and accessibility to avoid C++ rebuilds and CI timeouts.
Consistent UI updates across gems
Gems/AudioSystem/Code/Source/Editor/AudioSystemPanel.ui, Gems/LyShine/Code/Editor/Animation/UiAnimViewFindDlg.ui, Gems/LyShine/Code/Editor/Animation/UiAnimViewNodes.ui
Three search/filter QLineEdit fields now include placeholderText ("Search..." or "Search…"), clearButtonEnabled=true, and accessibleName="Search" for consistent UX and accessibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Zee2401/o3de#2: Both PRs update the Audio System Editor search/filter QLineEdit UX with placeholder text and clear button enabled, targeting the same AudioSystemPanel.ui external list filter.
  • Zee2401/o3de#1: Both PRs extend the search/filter UX pattern (placeholder text + clear button + guidance documentation) across LyShine and AudioSystem editor UI files via .Jules/palette.md and .ui definitions.

Poem

🐰 Three filters now search with grace,
Clear buttons gleaming in their place,
Placeholder text guides every soul,
A metadata touch—no rebuild toll,
CI smiles as wisdom takes the role!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: standardizing search field UX and accessibility across O3DE Editor UI files, which is the primary focus of the changeset.
Description check ✅ Passed The description covers what was changed and why, addressing both requirements from the template, though testing details could be more thorough.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-search-ux-improvements-3317471535877970760

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant