🎨 Palette: Standardize search field UX and accessibility#35
Conversation
…em and LyShine This commit improves the search fields in the Audio System Panel and LyShine Animation views by: - Enabling the clear button for faster search resets. - Adding accessible names to ensure screen reader support. - Standardizing placeholder text to "Search..." for better visual cues. These changes are implemented as metadata-only additions to .ui files to ensure build safety in large Gems. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe PR adds search field UX improvements across three O3DE gem editor panels by applying consistent metadata-only property updates to ChangesSearch Filter UX Improvements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Palette: Improved search field usability and accessibility in the O3DE Editor.
💡 What:
Added standard search properties to
QLineEditwidgets in three Editor UI files:Gems/AudioSystem/Code/Source/Editor/AudioSystemPanel.uiGems/LyShine/Code/Editor/Animation/UiAnimViewFindDlg.uiGems/LyShine/Code/Editor/Animation/UiAnimViewNodes.ui🎯 Why:
Standardizing search inputs improves consistency across the Editor. Specifically:
clearButtonEnabled: Allows users to quickly clear filters with one click.accessibleName: Provides a clear label for screen readers (improving accessibility beyond just placeholder text).placeholderText: Ensures "Search..." is used consistently as a prompt.♿ Accessibility:
Explicitly set
accessibleNameto "Search" on all modified fields to ensure they are properly identified by assistive technologies.Verified XML syntax for all modified files.
PR created automatically by Jules for task 3317471535877970760 started by @Zee2401
Summary by CodeRabbit
Documentation
Style