Skip to content

🎨 Palette: Standardize search and accessibility in Level File Dialog #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zee2401 wants to merge 4 commits into
base: development
Choose a base branch
from
Open

🎨 Palette: Standardize search and accessibility in Level File Dialog #38

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebab0de
Standardize search and accessibility in LevelFileDialog
google-labs-jules[bot] May 30, 2026
eb33852
Standardize search bar UX in AudioSystem Gem
google-labs-jules[bot] May 31, 2026
6740c87
Standardize accessibility and tooltips in Editor Console
google-labs-jules[bot] May 31, 2026
11037ea
Standardize accessibility and tooltips in Editor Console
google-labs-jules[bot] May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions Code/Editor/Controls/ConsoleSCB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,10 @@ CConsoleSCB::CConsoleSCB(QWidget* parent)

connect(ui->lineEdit, &ConsoleLineEdit::variableEditorRequested, this, &CConsoleSCB::showVariableEditor);

ui->label->setBuddy(ui->lineEditFind);
ui->lineEditFind->setAccessibleName(tr("Find"));
ui->lineEdit->setAccessibleName(tr("Console Input"));

AzToolsFramework::EditorPreferencesNotificationBus::Handler::BusConnect();
}

Expand Down Expand Up @@ -435,9 +439,20 @@ void CConsoleSCB::OnEditorPreferencesChanged()
void CConsoleSCB::RefreshStyle()
{
ui->button->setIcon(QIcon(ConsoleConstants::ButtonIcon));
ui->button->setToolTip(tr("Console Variables"));
ui->button->setAccessibleName(tr("Console Variables"));

ui->findButton->setIcon(QIcon(ConsoleConstants::SearchIcon));
ui->findButton->setToolTip(tr("Find"));
ui->findButton->setAccessibleName(tr("Find"));

ui->closeButton->setIcon(QIcon(ConsoleConstants::ClearIcon));
ui->closeButton->setToolTip(tr("Close Find Bar"));
ui->closeButton->setAccessibleName(tr("Close Find Bar"));

ui->optionsButton->setIcon(QIcon(ConsoleConstants::MenuIcon));
ui->optionsButton->setToolTip(tr("Console Options"));
ui->optionsButton->setAccessibleName(tr("Console Options"));
// Set the debug/warning text colors appropriately for the background theme
// (e.g. not have black text on black background)
QColor textColor = Qt::black;
Expand Down Expand Up @@ -1216,13 +1231,15 @@ ConsoleVariableEditor::ConsoleVariableEditor(QWidget* parent)
m_tableView->verticalHeader()->hide();
m_tableView->horizontalHeader()->hide();

// Setup a filter widget with a search label and line edit input for filtering
// the console variables
// Setup a filter widget with a line edit input for filtering the console variables
QWidget* m_filterWidget = new QWidget(this);
QLabel* label = new QLabel(tr("Search"), this);
QLineEdit* m_filterLineEdit = new QLineEdit(this);
m_filterLineEdit->setPlaceholderText(tr("Search..."));
m_filterLineEdit->setClearButtonEnabled(true);
m_filterLineEdit->setAccessibleName(tr("Search"));
AzQtComponents::LineEdit::applySearchStyle(m_filterLineEdit);

QHBoxLayout* filterlayout = new QHBoxLayout(m_filterWidget);
filterlayout->addWidget(label);
filterlayout->addWidget(m_filterLineEdit);

// Setup our model to be filterable by the name column from our line edit
Expand Down
Loading