Skip to content

🎨 Palette: Standardize search inputs in LyShine Animation UI #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zee2401 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

🎨 Palette: Standardize search inputs in LyShine Animation UI #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2025-05-14 - Standard Search/Filter Input Pattern in O3DE
**Learning:** O3DE (Open 3D Engine) uses a consistent UX pattern for search and filter fields in the Editor to improve usability and visual consistency. This involves setting localized placeholder text, enabling the built-in clear button, and applying the "Search" style class through the AzQtComponents framework.
**Action:** When implementing or enhancing search/filter inputs, ensure `<AzQtComponents/Components/Widgets/LineEdit.h>` is included, then call `setPlaceholderText()`, `setClearButtonEnabled(true)`, and `AzQtComponents::LineEdit::applySearchStyle()`.
## 2025-05-14 - [Standardizing Search Inputs in Qt UI]
**Learning:** O3DE UI uses standard Qt .ui files where QLineEdit search fields often lack modern UX features like clear buttons and placeholders. Adding these properties directly in the .ui file is a safe, metadata-only way to improve UX without triggering large C++ recompilations.
**Action:** Always check for QLineEdit widgets used as filters and add 'placeholderText', 'clearButtonEnabled', and 'accessibleName' properties. Also, link accompanying labels using the 'buddy' property for accessibility.
12 changes: 12 additions & 0 deletions Gems/LyShine/Code/Editor/Animation/UiAnimViewFindDlg.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
<property name="alignment">
<set>Qt::AlignTop|Qt::AlignLeft</set>
</property>
<property name="buddy">
<cstring>FILTER</cstring>
</property>
</widget>
</item>
<item>
Expand All @@ -42,6 +45,15 @@
<property name="alignment">
<set>Qt::AlignLeft|Qt::AlignVCenter</set>
</property>
<property name="placeholderText">
<string>Search...</string>
</property>
<property name="clearButtonEnabled">
<bool>true</bool>
</property>
<property name="accessibleName">
<string>Search</string>
</property>
</widget>
</item>
<item>
Expand Down
9 changes: 9 additions & 0 deletions Gems/LyShine/Code/Editor/Animation/UiAnimViewNodes.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,15 @@
<property name="focusPolicy">
<enum>Qt::ClickFocus</enum>
</property>
<property name="placeholderText">
<string>Search...</string>
</property>
<property name="clearButtonEnabled">
<bool>true</bool>
</property>
<property name="accessibleName">
<string>Search</string>
</property>
</widget>
</item>
<item row="2" column="1">
Expand Down
Loading