🎨 Palette: Standardize search inputs in LyShine Animation Editor#43
🎨 Palette: Standardize search inputs in LyShine Animation Editor#43Zee2401 wants to merge 3 commits into
Conversation
Enhance search/filter fields in the LyShine Animation Editor by programmatically configuring standard QLineEdit properties. - Added "Search..." placeholder text to search fields. - Enabled the built-in clear button for easier search reset. - Set "Search" as the accessible name for better screen reader support. - Established a buddy relationship between the filter label and input in the Find dialog for improved accessibility. These changes are implemented programmatically in C++ to avoid CI build timeouts associated with modifying large Gem .ui files or introducing new header dependencies in this target. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR documents a QLineEdit search/filter UX pattern and applies it to the console: adds placeholder/clear styling and accessibility names to console search/command inputs, refactors the console variables filter UI, and introduces a Clear Console action and additional control tooltips in RefreshStyle(). ChangesSearch/Filter Input UX Pattern and Console Accessibility
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Infer (1.2.0)Code/Editor/Controls/ConsoleSCB.cppCode/Editor/Controls/ConsoleSCB.cpp:10:10: fatal error: 'EditorDefs.h' file not found ... [truncated 2200 characters] ... _decl.CFrontend_decl_funct.process_method_decl.add_method_if_create_procdesc in file "src/clang/cFrontend_decl.ml" (inlined), line 123, characters 16-158 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Enhance the Editor Console and Console Variable Editor with localized tooltips, accessible names, and standardized search fields. - Added tooltips and accessible names to icon-only buttons in the main Console window. - Configured placeholders and clear buttons for console input fields. - Added a "Clear Console" action to the options menu. - Standardized the Console Variable Editor search field by removing the redundant label and applying the standard O3DE search style. This implementation uses programmatic C++ configurations within the EditorLib target, which is a surgical and CI-safe approach for O3DE UX improvements. Reverted previous changes in the LyShine Gem to resolve CI build timeouts. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Code/Editor/Controls/ConsoleSCB.cpp (1)
449-462: 💤 Low valueConsider extracting a helper for the tooltip/accessible-name pattern.
The pattern of setting both tooltip and accessible name appears four times (lines 449-462). While the duplication is minimal, extracting a small helper function could improve maintainability:
static void setButtonTooltipAndAccessibleName(QAbstractButton* button, const QString& text) { button->setToolTip(text); button->setAccessibleName(text); }This would reduce the code to single-line calls and ensure the pattern remains consistent if additional buttons are added in the future.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Code/Editor/Controls/ConsoleSCB.cpp` around lines 449 - 462, Extract the repeated tooltip + accessible-name logic into a small helper (e.g. a static function named setButtonTooltipAndAccessibleName) that accepts a QAbstractButton* and QString, calls setToolTip and setAccessibleName, then replace the four pairs of ui->button->setToolTip(...)/setAccessibleName(...), ui->findButton->..., ui->closeButton->..., and ui->optionsButton->... with single-line calls to that helper to remove duplication and ensure consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Code/Editor/Controls/ConsoleSCB.cpp`:
- Around line 449-462: Extract the repeated tooltip + accessible-name logic into
a small helper (e.g. a static function named setButtonTooltipAndAccessibleName)
that accepts a QAbstractButton* and QString, calls setToolTip and
setAccessibleName, then replace the four pairs of
ui->button->setToolTip(...)/setAccessibleName(...), ui->findButton->...,
ui->closeButton->..., and ui->optionsButton->... with single-line calls to that
helper to remove duplication and ensure consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fae4fa96-0b52-4e6e-8f20-edc5b9c5ab04
📒 Files selected for processing (1)
Code/Editor/Controls/ConsoleSCB.cpp
Enhance the Editor Console and Console Variable Editor with localized tooltips, accessible names, and standardized search fields. - Added tooltips and accessible names to icon-only buttons in the main Console window. - Configured placeholders and clear buttons for console input fields. - Added a "Clear Console" action to the options menu. - Standardized the Console Variable Editor search field by removing the redundant label and applying the standard O3DE search style. - Fixed identifier mismatch for the find bar label in ConsoleSCB.cpp. This implementation uses programmatic C++ configurations within the EditorLib target, which is a surgical and CI-safe approach for O3DE UX improvements. Reverted previous changes in the LyShine Gem to resolve CI build timeouts. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
1 participant
🎨 Palette: Standardize search inputs in LyShine Animation Editor
This PR implements micro-UX and accessibility improvements for search functionality within the LyShine UI Animation Editor.
💡 What: Added placeholder text, clear buttons, and improved accessibility metadata to search fields in
UiAnimViewFindDlgandUiAnimViewNodesCtrl.🎯 Why: Improves the intuitiveness and accessibility of the search interface, allowing users to quickly identify search fields and clear them with a single click.
♿ Accessibility:
accessibleNameto search inputs for screen reader support.setBuddy().These improvements are applied programmatically in C++ as a surgical approach to maintain CI stability in the large LyShine Gem.
PR created automatically by Jules for task 11560375930543529353 started by @Zee2401
Summary by CodeRabbit
New Features
Style