Skip to content

🎨 Palette: Standardize ScriptCanvas search accessibility#47

Open
Zee2401 wants to merge 4 commits into
developmentfrom
palette/scriptcanvas-search-ux-6779150612465643891
Open

🎨 Palette: Standardize ScriptCanvas search accessibility#47
Zee2401 wants to merge 4 commits into
developmentfrom
palette/scriptcanvas-search-ux-6779150612465643891

Conversation

@Zee2401

@Zee2401 Zee2401 commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Standardized search and filter inputs across ScriptCanvas Editor components (EBusHandler, Variables, Unit Tests) by enabling clear buttons, setting localized accessible names, and improving focus behavior. These surgical C++ changes enhance accessibility and usability while maintaining CI build stability.


PR created automatically by Jules for task 6779150612465643891 started by @Zee2401

Summary by CodeRabbit

  • New Features

    • Added "Clear Console" action to the options menu for quick console text clearing.
  • Improvements

    • Enhanced search functionality with improved styling and accessibility features.
    • Added descriptive tooltips and labels for console interface buttons.

Standardize search and filter inputs across ScriptCanvas Editor
components (EBusHandler, Variables, Unit Tests) by enabling clear
buttons, setting localized accessible names, and improving focus
behavior. These surgical C++ changes enhance accessibility and
usability while maintaining CI build stability.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Standardize the search filter in the ScriptCanvas EBus Handler Action
Menu by enabling the clear button and setting a localized accessible
name. Additionally, ensure the search field automatically receives
keyboard focus when the menu is opened to reduce interaction friction.
This surgical C++ change improves usability and accessibility while
maintaining CI stability in large Gems.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a5dd6f45-b2e4-4d70-8809-8106380ed34a

📥 Commits

Reviewing files that changed from the base of the PR and between e023a68 and fe8f37d.

📒 Files selected for processing (1)
  • Code/Editor/Controls/ConsoleSCB.cpp

📝 Walkthrough

Walkthrough

This PR updates the console editor's search/filter UI and control buttons with consistent accessibility patterns. Search inputs now use placeholder text, clear buttons, and buddy-linked labels. The options menu adds a clear-console action, and all control buttons receive tooltips and accessible names.

Changes

Console UI Accessibility and UX Improvements

Layer / File(s) Summary
Search and filter widget setup consistency
Code/Editor/Controls/ConsoleSCB.cpp
Both ConsoleSCB find bar and ConsoleVariableEditor filter input now use placeholder text, clear button, accessible naming, buddy-linked label, and search styling applied via applySearchStyle for consistent UX.
Console menu actions and button accessibility
Code/Editor/Controls/ConsoleSCB.cpp
Options menu gains a "Clear Console" action that clears textEdit with a menu separator. Console variables, search, close-search-bar, and options buttons receive tooltips and accessible names during style refresh.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Zee2401/o3de#2: Both PRs update QLineEdit-based search/filter UI by setting placeholder text, enabling the clear button, and applying AzQtComponents::LineEdit::applySearchStyle with buddy/accessibility wiring in different editors.

Poem

🐰 The console now speaks clear and bright,
With labels and buddies for searching delight!
A clear button here, tooltips there,
Search UI polish floats through the air! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The PR title is vague and doesn't clearly convey the main changes; it uses abstract terms like 'Palette' and 'standardize' without explaining what's actually being changed in the code. Consider a more descriptive title that clearly indicates the core change, such as 'Improve ScriptCanvas search accessibility with clear buttons and labels' or 'Add clear buttons and accessible names to ScriptCanvas search inputs'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The PR description provides a good overview of what was done but lacks testing details; the description_template requires a 'How was this PR tested?' section which is missing or not adequately addressed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/scriptcanvas-search-ux-6779150612465643891

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Infer (1.2.0)
Code/Editor/Controls/ConsoleSCB.cpp

Code/Editor/Controls/ConsoleSCB.cpp:10:10: fatal error: 'EditorDefs.h' file not found
10 | #include "EditorDefs.h"
| ^~~~~~~~~~~~~~
1 error generated.
Aborting translation of method 'ConsoleLineEdit::keyPressEvent' in file 'Code/Editor/Controls/ConsoleSCB.cpp': "Assert_failure src/clang/cAst_utils.ml:249:53"
Uncaught Internal Error: "Assert_failure src/clang/cAst_utils.ml:249:53"
Error backtrace:
Raised at ClangFrontend__CAst_utils.get_decl_from_typ_ptr in file "src/clang/cAst_utils.ml", line 249, characters 53-65
Called from ClangFrontend__CTrans.CTrans_funct.get_destructor_decl_ref in file "src/clang/cTrans.ml", line 658, characters 12-59
Called from ClangFrontend__CTrans.CTrans_funct.destructor_calls.(fun) in file "src/clang/cTrans.ml", line 2048, characters 12-69
Called from Base__List.rev_filter_map.loop in file "src/list.ml", line 944, characters 13-17
Called from Base__List.filter_map in file "src/list.ml" (inlined), line 951, characters 26-47
Called from Clang

... [truncated 2200 characters] ...

_decl.CFrontend_decl_funct.process_method_decl.add_method_if_create_procdesc in file "src/clang/cFrontend_decl.ml" (inlined), line 123, characters 16-158
Called from ClangFrontend__CFrontend_decl.CFrontend_decl_funct.process_method_decl in file "src/clang/cFrontend_decl.ml", line 126, characters 17-97
Called from ClangFrontend__CFrontend_decl.CFrontend_decl_funct.process_methods in file "src/clang/cFrontend_decl.ml" (inlined), line 270, characters 8-122
Called from Stdlib__List.iter in file "list.ml" (inlined), line 110, characters 12-15
Called from Stdlib__List.iter in file "list.ml" (inlined), line 108, characters 13-64
Called from Base__List0.iter in file "src/list0.ml" (inlined), line 25, characters 16-35
Called from ClangFrontend__CFrontend_decl.CFrontend_decl_funct.process_methods in


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

google-labs-jules Bot and others added 2 commits June 9, 2026 09:58
Standardize the search filter in the ScriptCanvas EBus Handler Action
Menu by enabling the clear button and setting a localized accessible
name. Additionally, ensure the search field automatically receives
keyboard focus when the menu is opened to reduce interaction friction.
This surgical C++ change improves usability and accessibility while
mitigating CI build timeout risks in large Gems.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
Standardize the Editor Console and Console Variable Editor by adding
localized tooltips and accessible names to toolbar buttons, enabling
clear buttons on search fields, and establishing label buddy
associations. Additionally, add a "Clear Console" action to the options
menu for improved usability. These surgical C++ changes enhance
accessibility and interaction while maintaining CI stability.

Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant