🎨 Palette: Standardize ScriptCanvas search accessibility#47
Conversation
Standardize search and filter inputs across ScriptCanvas Editor components (EBusHandler, Variables, Unit Tests) by enabling clear buttons, setting localized accessible names, and improving focus behavior. These surgical C++ changes enhance accessibility and usability while maintaining CI build stability. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Standardize the search filter in the ScriptCanvas EBus Handler Action Menu by enabling the clear button and setting a localized accessible name. Additionally, ensure the search field automatically receives keyboard focus when the menu is opened to reduce interaction friction. This surgical C++ change improves usability and accessibility while maintaining CI stability in large Gems. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the console editor's search/filter UI and control buttons with consistent accessibility patterns. Search inputs now use placeholder text, clear buttons, and buddy-linked labels. The options menu adds a clear-console action, and all control buttons receive tooltips and accessible names. ChangesConsole UI Accessibility and UX Improvements
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Infer (1.2.0)Code/Editor/Controls/ConsoleSCB.cppCode/Editor/Controls/ConsoleSCB.cpp:10:10: fatal error: 'EditorDefs.h' file not found ... [truncated 2200 characters] ... _decl.CFrontend_decl_funct.process_method_decl.add_method_if_create_procdesc in file "src/clang/cFrontend_decl.ml" (inlined), line 123, characters 16-158 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Standardize the search filter in the ScriptCanvas EBus Handler Action Menu by enabling the clear button and setting a localized accessible name. Additionally, ensure the search field automatically receives keyboard focus when the menu is opened to reduce interaction friction. This surgical C++ change improves usability and accessibility while mitigating CI build timeout risks in large Gems. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
Standardize the Editor Console and Console Variable Editor by adding localized tooltips and accessible names to toolbar buttons, enabling clear buttons on search fields, and establishing label buddy associations. Additionally, add a "Clear Console" action to the options menu for improved usability. These surgical C++ changes enhance accessibility and interaction while maintaining CI stability. Co-authored-by: Zee2401 <210601625+Zee2401@users.noreply.github.com>
Standardized search and filter inputs across ScriptCanvas Editor components (EBusHandler, Variables, Unit Tests) by enabling clear buttons, setting localized accessible names, and improving focus behavior. These surgical C++ changes enhance accessibility and usability while maintaining CI build stability.
PR created automatically by Jules for task 6779150612465643891 started by @Zee2401
Summary by CodeRabbit
New Features
Improvements