add a safety check for invalid request #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndieAuth\Client (https://github.com/indieweb/indieauth-client-php) does not send 'me' in the query parameters. This change should more gracefully handle that issue.
|
I have also added a change to IndieAuth\Client to support this: indieweb/indieauth-client-php#26 |
|
It seems like there is already a commit here that would eliminate this, but it is not merged to master: 8333eeb |
carrvo
commented
Nov 29, 2024
|
In accordance with the conversation with the IndieWeb, I am closing this as an outdated spec feature. The proper solution already has an un--merged commit to resolve. See the above comments for links and details. |
|
Note: #14 was created to merge the solution in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndieAuth\Client (https://github.com/indieweb/indieauth-client-php) does not send 'me' in the query parameters.
This change should more gracefully handle that issue.