-
Notifications
You must be signed in to change notification settings - Fork 1
Update documentation for port section #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
zq2/docs/nodes/node.md
Outdated
public internet. | ||
|
||
#### Optional | ||
|
||
4201/TCP - JSONRPC over HTTP: API port, only necessary if you want your API to | ||
4201/TCP,4202/TCP - JSONRPC over HTTP: API port, only necessary if you want your API to | ||
be accessible via the internet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks not 100% true considering you can want to have the endpoint available on a private network
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any hint @pavlops @DrZoltanFazekas @shawn-zil @chetan-zilliqa ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're currently separating it:
- 4201 - public API
- 4202 - private API.
Which sets of RPC functions to expose, is currently controlled via the config. So, the above separation is somewhat arbitrary. If they want all their RPC exposed on the internet, they can expose all of it on 4201.
So, I think that recommending 4201/TCP as a public RPC port, makes sense from a standardisation point of view. However, the private RPC port, should be freely chosen by the user (if they want one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, let me revert then. Thanks
No description provided.