-
Notifications
You must be signed in to change notification settings - Fork 2
connector-v2 -- main as base #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
miguel-nascimento
wants to merge
42
commits into
main
Choose a base branch
from
connector-v2-using-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
After the base change, applet run isn't working. Probably due to a change in the boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
main
branch as base this time. Made using rebase, this PR is only to use the GitHub UI in order to compare both PRConnectors v2
Connectors v2 went through many tests until we got a MVP. This document explains the different ways we tried, the things we thought about at each step, and where we are headed.
Connectors as Code
The idea with connectors as code was to put all possible settings directly into the code, creating objects like
slackConfig
orgithubConfig
.These would have information about the connector like
clientId
,botScopes
, anduserScopes
. This way, we could easily change the values in the code to set up any connector.To save and get these values, we used
ts-morph
, but that caused some problems. Users could change the connector config to non-literal values.For example:
In order to grab value from
.env
, or grab any dynamic value, we would need to run the code. And tools likets-morph
cant do this. This invalidates theconnector-as-code
approach.We need to run and get the config.
Connectors as Handler (Current Version)
The connectors as a handler approach is similar to connectors as code, but now we use the handler to run the applet and get the config.
This solves the problem of non-literal values and handles OAuth-related issues by using other applets to get links, like slack-install-link.
This way, connectors can work in different ways based on actions, like just giving back the configurations or doing OAuth, for example,
case “get-auth-url”
orcase “get-config”
.There are some concerns with this method, though. Some connectors might need code execution and HTTP calls, which could take a long time or might fail.
If zipper.run has downtimes, the connectors won’t work.
Other issues include:
Current things missing: