WIP - 9 - chat. #222
Open
WIP - 9 - chat. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinlarsson
added
site-wide
Zomis
requested changes
Apr 11, 2021
| }, | ||
| computed: { | ||
| chats() { | ||
| return this.$store.state.chat.chats; |
There was a problem hiding this comment.
Using this.$store.state is not correct. See for example InviteScreen.vue for an example of how to use mapState to make reactivity work correctly
| mutations: { | ||
| addChat(state, data) { | ||
| const { chatId, users } = data; | ||
| state.chats[chatId] = { chatId, users } |
There was a problem hiding this comment.
This needs to use Vue.set (see DslGameState.js for an example) in order to make the property reactive.
There was a problem hiding this comment.
Oh, I didn't see that one yet, nice!
|
Will wait with merging this until the backend is finished so that it can be tested more properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
TODO
Related Issues
#16
#9
Closed
Default chat
Select another chat