fix(release): install deps before merging macOS updater manifests#73
fix(release): install deps before merging macOS updater manifests#73aaditagrawal merged 1 commit intomainfrom
Conversation
…ests The 'Publish GitHub Release' job invokes scripts/merge-update-manifests.ts which imports from @effect/platform-node. Without a prior bun install step the release runner has no node_modules, so the script fails with: error: Cannot find module '@effect/platform-node/NodeServices' from /home/runner/work/t3code/t3code/scripts/merge-update-manifests.ts Upstream's release job includes an 'Install dependencies' step between Setup Node and Download artifacts (they run merge-update-manifests via `node` too — same dep resolution requirement). Mirror that step in the fork's simplified release flow. Failed run: https://github.com/aaditagrawal/t3code/actions/runs/24624988376/job/72002885256
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded an explicit dependency installation step to the GitHub Actions release workflow. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Adds `bun install --frozen-lockfile` between `Setup Node` and `Download all desktop artifacts` in the `Publish GitHub Release` job.
Why
The release job failed on `main` (run 24624988376) with:
```
error: Cannot find module '@effect/platform-node/NodeServices' from
/home/runner/work/t3code/t3code/scripts/merge-update-manifests.ts
```
`scripts/merge-update-manifests.ts` imports from `@effect/platform-node` — no `node_modules` present on the release runner means the import can't resolve. Upstream's release job includes an `Install dependencies` step before `Download all desktop artifacts`; fork's simplified flow dropped it when we stripped the nightly/npm-publish steps.
Test plan
Summary by CodeRabbit