Skip to content

fix(release): install deps before merging macOS updater manifests#73

Merged
aaditagrawal merged 1 commit intomainfrom
fix/release-workflow-install
Apr 19, 2026
Merged

fix(release): install deps before merging macOS updater manifests#73
aaditagrawal merged 1 commit intomainfrom
fix/release-workflow-install

Conversation

@aaditagrawal
Copy link
Copy Markdown
Owner

@aaditagrawal aaditagrawal commented Apr 19, 2026

What

Adds `bun install --frozen-lockfile` between `Setup Node` and `Download all desktop artifacts` in the `Publish GitHub Release` job.

Why

The release job failed on `main` (run 24624988376) with:

```
error: Cannot find module '@effect/platform-node/NodeServices' from
/home/runner/work/t3code/t3code/scripts/merge-update-manifests.ts
```

`scripts/merge-update-manifests.ts` imports from `@effect/platform-node` — no `node_modules` present on the release runner means the import can't resolve. Upstream's release job includes an `Install dependencies` step before `Download all desktop artifacts`; fork's simplified flow dropped it when we stripped the nightly/npm-publish steps.

Test plan

  • Kick off `Release Desktop` workflow after merge — `Merge macOS updater manifests` step should succeed.

Summary by CodeRabbit

  • Chores
    • Enhanced release pipeline to ensure dependencies are properly installed during the publication stage.

…ests

The 'Publish GitHub Release' job invokes scripts/merge-update-manifests.ts
which imports from @effect/platform-node. Without a prior bun install step
the release runner has no node_modules, so the script fails with:

  error: Cannot find module '@effect/platform-node/NodeServices' from
  /home/runner/work/t3code/t3code/scripts/merge-update-manifests.ts

Upstream's release job includes an 'Install dependencies' step between
Setup Node and Download artifacts (they run merge-update-manifests via
`node` too — same dep resolution requirement). Mirror that step in the
fork's simplified release flow.

Failed run: https://github.com/aaditagrawal/t3code/actions/runs/24624988376/job/72002885256
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f8650026-aa92-43c6-8416-22ca336a9345

📥 Commits

Reviewing files that changed from the base of the PR and between 52e015c and 3e54dc3.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

Added an explicit dependency installation step to the GitHub Actions release workflow. The release job now runs bun install --frozen-lockfile after setting up Bun and Node, ensuring dependencies are available before artifact download and release publishing steps.

Changes

Cohort / File(s) Summary
Release Workflow Configuration
.github/workflows/release.yml
Added explicit bun install --frozen-lockfile step to the release job to ensure dependencies are installed before downstream artifact and publishing operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

vouch:trusted, size:M

Poem

🐰 A hop and a skip, with bun we install,
In the release job, dependencies answer the call,
Locked and bundled, so steady and true,
Before publishing code to the world anew,
One tiny step, a safeguard of care,
The release flows smoothly through the air! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding a dependency installation step before merging macOS updater manifests in the release workflow.
Description check ✅ Passed The description includes all required sections from the template ('What Changed' and 'Why') with clear explanations and a test plan. UI Changes section is appropriately omitted as not applicable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-workflow-install

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 effective changed lines (test files excluded in mixed PRs). labels Apr 19, 2026
@aaditagrawal aaditagrawal merged commit 26ca6ec into main Apr 19, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant