fix(providers): rename deepseek-v4-flash to deepseek-flash - #12269
Open
michaelneale wants to merge 2 commits into
Open
michaelneale wants to merge 2 commits into
michaelneale wants to merge 2 commits into
Conversation
DeepSeek retired the deepseek-v4-flash name; requests are now served by DeepSeek-V4.1-Flash under the deepseek-flash model name. Update the bundled provider definition so the desktop model list and default show the current name. Closes #12218
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c646d822c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Collaborator
Author
|
🤖 Addressed the codex feedback: dropped the stale 128K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12218
DeepSeek retired the
deepseek-v4-flashmodel name — requests to it are now served by DeepSeek-V4.1-Flash, and the current name isdeepseek-flash(per DeepSeek's deprecation notice quoted in the issue). Since the bundleddeepseek.jsondefinition is compiled into the binary, the desktop model picker keeps showing the stale name until a release ships this update.Changes
crates/goose-providers/src/declarative/definitions/deepseek.json:deepseek-v4-flash→deepseek-flash.Out of scope: gateway/aggregator definitions (fireworks, empiriolabs, opencode, etc.) expose their own model IDs, and DeepSeek still accepts the legacy names, so nothing breaks there.
Verification
cargo test -p goose-providerspasses (definitions are validated at load).