fix: treat SQLite timestamps as UTC when computing elapsed time - #14
Open
anshusaurav wants to merge 1 commit into
Open
anshusaurav wants to merge 1 commit into
anshusaurav wants to merge 1 commit into
Conversation
datetime.fromisoformat() on a naive timestamp produces a naive datetime; .timestamp() then assumes local time. time.time() returns UTC epoch seconds, so the subtraction was off by the user's UTC offset — showing hours instead of minutes. Add a _utc_epoch() helper that tags naive datetimes as UTC before converting. Apply it to both elapsed_seconds (created_at) and infer_status (updated_at). Closes aaif-goose#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime.fromisoformat()on a naive SQLite timestamp produces a naive datetime, and.timestamp()assumes local time — buttime.time()returns UTC epoch seconds. The difference equals the user's UTC offset._utc_epoch()helper that tags naive datetimes as UTC before converting to epoch. Applied to bothelapsed_seconds(fromcreated_at) andinfer_status(fromupdated_at).tests/test_elapsed.py.Test plan
test_naive_timestamp_treated_as_utc— naive ISO string → UTC epochtest_aware_timestamp_preserved— timezone-aware string keeps its offsettest_elapsed_is_small_for_recent_session— a just-created session shows ~0s, not hourstest_space_separator_handled— SQLite space separator handled correctlyCloses #13