Skip to content

feat: add security protocol options on kafka settings #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
av-dev2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add security protocol options on kafka settings #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bulkwebhook/bulk_webhook/doctype/kafka_settings/confluent_kafka_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def get_confluent_kafka_client(settings_doc):
conf = {
"bootstrap.servers": settings_doc.bootstrap_servers,
"client.id": settings_doc.client_id,
"security.protocol": "SASL_SSL",
"security.protocol": settings_doc.security_protocol,
"sasl.mechanism": "PLAIN",
"sasl.username": settings_doc.get_password("api_key"),
"sasl.password": settings_doc.get_password("api_secret"),
Expand Down Expand Up @@ -144,6 +144,10 @@ def run_kafka_hook_for_protobuf(kafka_hook, doctype, doc=None, doc_list=None):
create_kafka_request_log(doctype=kafka_hook.webhook_doctype, status="sending to kafka", doc_list=doc_list)

settings_doc = frappe.get_cached_doc("Kafka Settings", kafka_hook.kafka_settings)
if not settings_doc.security_protocol:
frappe.throw(
"Security Protocol is required for Kafka Settings, please set it on the Kafka Settings document."
)
schema_registry_client = get_schema_registry_client(settings_doc)
producer = get_confluent_kafka_producer(settings_doc)

Expand Down
15 changes: 14 additions & 1 deletion bulkwebhook/bulk_webhook/doctype/kafka_settings/kafka_settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
"client_id",
"api_key",
"api_secret",
"column_break_9vzjb",
"security_protocol",
"ksc_sec",
"schema_regestry_url",
"username",
Expand Down Expand Up @@ -69,11 +71,22 @@
"fieldname": "password",
"fieldtype": "Password",
"label": "Password"
},
{
"fieldname": "column_break_9vzjb",
"fieldtype": "Column Break"
},
{
"fieldname": "security_protocol",
"fieldtype": "Select",
"label": "Security Protocol",
"options": "\nSSL\nSASL_SSL\nPLAINTEXT\nSASL_PLAINTEXT",
"reqd": 1
}
],
"index_web_pages_for_search": 1,
"links": [],
"modified": "2023-03-16 14:35:09.517429",
"modified": "2024-03-21 14:39:20.403911",
"modified_by": "Administrator",
"module": "Bulk Webhook",
"name": "Kafka Settings",
Expand Down