Repository navigation
Study scene: shelf fill level, Librarian's open book, reading room in place of the observatory - #28
Merged
Conversation
added 4 commits
September 28, 2026 01:10
…le spines An archived commission darkened one painted spine, and the wall could mark twenty-two of them, spread four to a shelf. However much work had been finished, the wall read as a book lit here and there among several hundred that could never change, so it said nothing about how much was archived. Each mark is now a bay: the run of books standing between two posts on one shelf, up to the shelf above. Fifty-three bays cover the painted books of the whole wall, and they are handed out along each shelf, top shelf first, so the archive reads as a level rising through the wall. The bays were measured from the painting, and they stop short of the things on the wall that are not books. A lamp stays lit, because a shade darkened along with the books beside it reads as the light going out. The ladder and the cat stand in front of the shelves, so they are left alone too. The commission number stays pasted on one spine at the foot of the bay, a quarter as wide as the shelf is tall. Sized from the bay it would be a plate across several books with a glyph taller than any of them. Two existing checks assumed a mark was a single spine and are restated for bays. "Most of the mark is not shelving-coloured" cannot hold for a bay, because the wall paints many of its books in the same brown as the carpentry, so the check is now that no mark reaches onto a ledge or a post, both found from the paint. "Every slot is narrower than tall" guarded an earlier refactor of the hover ring, so it now asserts the ring a bay gets is sized for the shelf, not for the width of the run.
…ed total The page-turn films were bounded at 700,000 bytes for the whole set, which was sized for the eight desks the house had. Any desk added after that has a film of its own, and a fixed total leaves the next one to choose between the budget and the film. The bound is now 87,500 bytes a desk, the same per-clip allowance the original eight were held to, so it still fails when a clip is regenerated at a longer duration or a higher resolution.
Every reading desk in the Study turns the pages of the book painted on it with a short film of that desk, but the keeper's study was painted with a quill and an inkwell and nothing to read. His berth had no volume, so his commission was the one book in the house still drawn over bare wood with a leaf swung on a keyframe. The panel is repainted with an open book on the front of the desk. Nothing else in the room moves, apart from the inkstand and quill it replaces. The berth declares that book as its volume, so the card stands behind it, and a page-turn clip filmed from the new panel plays there. The crop is 384x216 rather than the reading rooms' 288x162, because this book is wider than their window. There is no candle in the room to keep out of frame. Both art sheets record how the panel and the clip were made. The panel's reference is the previous revision of the same file, identified by digest.
The room on the top storey beside the shelves was an observatory: a whole storey spent on one prop, whose only use was a click through to the triggers tab. It was the one room on the floor nobody had a reason to look at. It is now a fifth reading room with two desks, each with a painted open book and a page-turn film cut from the new panel like every other desk. The triggers stay where they were in function but not in space: the almanac is a prop on a lectern in the new room's corner, the way the parlour holds the petitions and the fire. The room is authored last in the plan, so the seats assistants already hold do not move, and its desks fill once the other eight are taken. Its walls are moss green, the widest gap left among the reading rooms' hues (tan, teal, crimson, indigo). That is now a test: the wall hue of every reading room is measured off its panel, and no two may be within 20 degrees. The panel exposed a gap in the desk probe used by the berth checks. It called a pixel wood if it was dark and red over blue, which a dark moss wall also is, so it read two thirds of the green room as furniture. Wood is warm, so the probe now also requires red over green. The other rooms measure the same as before. Tests that counted the house as it was are restated from the plan: the filmed desk count, the number of readers needed to force a shared desk, the ambiance order (compared in drawn order, since authored order is seating order), and the binding check, which is about the two right-hand repaints and not about every room on that side.
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three follow-ups to the study scene after the first run of the Sixth History theme.
Shelf wall fills bay by bay (C). Archive slots are now the 53 bays between the shelf posts, measured off the paint, handed out top shelf first and left to right, so the wall reads as a fill level rather than a spine here and there. Lamps, ladder and cat stay clear; the number label is one spine wide.
The Librarian's desk has an open book (A).
room-god-study.pngis repainted with a volume in place of the inkstand and quill; the god berth declares it, and a page-turn film (book-turn-god.mp4) plays while reading. The old keyframe leaf is gone.The observatory becomes a reading room (B). The
almanacroom (row 0, col 1) is replaced by a moss-green two-desk reading room (room-desk-g.png, berths 9 and 10, painted books and page-turn clips). Triggers stays reachable: the almanac is now a prop on a lectern in that room, which satisfies the one-almanac-anchor validator. The room is authored last, so existing seats do not move and it fills once eight desks are taken. A new test rejects two reading rooms within 20° of wall hue.Rule change, please confirm: the page-turn clip budget is now 87,500 bytes per desk instead of a fixed 700,000 total (the three new clips would take the total to ~826K). Per-clip allowance unchanged; the revert is a one-liner if re-encoding or a different cap is preferred.
Verification: typecheck 0, build succeeds with the new assets and no
room-almanac; full suite 1438/1499 with the failing set identical by name to the base commit (sandbox-bound plus one pre-existing date-rot test). Each new test was mutation-checked red (bay on a ledge, bay on a lamp, label thickness, volume off the book, same-colour panel). A real Study screenshot is still needed after a pull and restart.