Repository navigation
Study: the Librarian card keeps its own portrait - #31
Merged
aaroncoville merged 1 commit intoSep 28, 2026
Merged
Conversation
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Librarian's Study card goes back to its own portrait.
The square house mark on the rectangular card read wrong in the live run. The card now uses the reserved pre-#27 portrait asset (
assets/portraits/fascination.png), narrowed at the card's final seam only:portraitFor({ isGod: true })still returns the house mark for the small shared avatars, and packaged icons, Focus and other branding are untouched.Scope:
AgentCard.tsxand its test. The regression was written red against the square mark first; focused suite 65 pass, typecheck, production build and diff-check clean.