Repository navigation
Study: each archived commission darkens one painted spine - #32
Merged
Merged
Conversation
The shelf wall marked finished work a bay at a time: the run of books between two posts on one shelf, fifty-three of them across the wall. A bay is several books standing for one commission, so the wall could only ever say roughly how much had been finished, and it was full after fifty-three. Each mark is now a single painted spine, 341 of them, handed out along each shelf with the top shelf first, so one concluded commission darkens exactly one book and the wall still fills as a level. The spines were measured from the painting inside the existing bays, which already stop clear of the posts, the ledges, the lamps, the ladder and the cat. A spine's sides are where the column colour of the paint changes, with the pale painted titles left out so a glyph is not read as the edge between two books; a run too wide to be one book is split at its strongest remaining edge; a spine's top is the first row, going down, whose paint is that book's own colour. Past 341 the oldest commission leaves the wall, as it did before: the wall is a ceiling rather than a cycle, so no book is ever marked twice. Tests: a new check that every mark is a standing book (narrower than it is tall, which no bay was) and that one archived commission renders exactly one mark, on the first spine. The coverage check now measures along the foot of each shelf, because a spine rightly stops at its own top and the whole-panel probe counted the dark wall above a short book as a book the marks had missed. The fill-order check compares where spines stand rather than their tops, which differ along a shelf, and the no-overlap check allows for two rounded fractions meeting at a shared edge.
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each archived commission now darkens one painted spine instead of one bay.
The shelf wall's archive unit moves from 53 bays to 341 individual books, measured off the existing paint inside the bays that already stop clear of posts, ledges, lamps, ladder and cat: spine sides come from column-colour edges (ignoring the pale title glyphs), runs over 30px split at the strongest remaining edge, and each spine top is the first row that is the book's own colour. Fill order is unchanged, top shelf first, left to right. No art was regenerated.
Past capacity is a documented ceiling, not a wrap: the newest 341 are kept, the oldest leaves the wall, and no spine is marked twice, matching the existing oldest-off rule on
ARCHIVE_MAX.Tests: two new (every mark is a standing book with w < 0.75h, which no bay met; one archived commission renders exactly one mark, spine 0) and four restated, with shelf-foot coverage measured at 87% against a bar raised to 80%. Scope:
shelfBooks.ts, a doc comment inShelfArchive.tsx, and two test files. Note for later:ARCHIVE_WINDOW_DAYSis still 14, so the wall only fills if that many commissions finish inside two weeks.