Repository navigation
chore(release): label the fork 0.5.5-sixth.1 - #42
Merged
Merged
Conversation
The fork carries upstream's public source up to and past its 0.5.5 tag, plus its own theme and fixes, but package.json still said 0.4.6, the last version upstream's public source declares. The app therefore described itself as two releases older than it is. Its releases/latest check also offered upstream's 0.5.5 installer as an update, even though this build already contains that public source. The version is now 0.5.5-sixth.1, in package.json and package-lock.json. The updater compares major.minor.patch and discards the suffix, so the label reads as 0.5.5: upstream's 0.5.5 is no longer offered, and 0.5.6 or later still is. A test reads the real package version and holds it to both. On the first launch after the upgrade from 0.4.6 the release notes open once, as for any upgrade.
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels the fork
0.5.5-sixth.1: parity with upstream public 0.5.5 plus the themed branch. The updater compares it as 0.5.5, so the releases notifier stops offering upstream 0.5.5 and still offers 0.5.6 and later. A test reads the real package.json version and pins both behaviours.Not verified: electron-builder packaging with a prerelease semver (only the vite build was run).