Repository navigation
test(study): the orchestrator's card wears the Librarian portrait - #43
Merged
Merged
Conversation
The scene test for the orchestrator's card failed on every run. It still expected the Sixth History logo with the square House-mark treatment, but the orchestrator's portrait had since moved to the reserved Librarian portrait (fascination.png, cropped like any other portrait). That change updated the portrait and face tests and missed this one. The code is right and the test was stale. It now asserts the card is dealt the Librarian portrait and is still flagged as the orchestrator's, the flag the card uses to choose that portrait itself. Dealing the orchestrator a worker's face, or dropping the flag from the scene, turns it red.
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The study-scene test still expected the orchestrator card to carry the House logo. The portrait was deliberately switched to the Librarian's own portrait in #41, and that commit updated the other three portrait tests but missed this assertion.
Test-only change: the god card's portrait is now asserted as
portraits/fascination.png, andhouseMarkis still asserted true (AgentCard still uses the flag to pick the portrait). Mutations that deal the god a worker's face, or drophouseMark, turn it red.Suite: 1701/1703, 0 failing (base: 1 failing).