Avoid the use of navigator on server side
#58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinreber
approved these changes
Jan 6, 2024
kevinreber
left a comment
kevinreber
left a comment
There was a problem hiding this comment.
not sure how active the owner is, but LGTM!
|
@DovahBrownies Have you published a new package with this fix included? If yes I really appreciated it you would share it with us! |
Author
This package didn't perform as smoothly as I had initially wanted, for my specific needs. So I didn't end up using it at all. |
|
What did you use instead of this package @DovahBrownies? |
Author
I ended up creating my own component that behaves exactly the way I want it to. |
|
Haha. That's always very tempting. 😆
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward;
navigatorwill obviously throw an error on the server side due to not existing outside the browser. This is a simple work around.