fix(ci): prevent corrupted Metal wheel releases - #2379
Open
provoke210 wants to merge 2 commits into
Open
provoke210 wants to merge 2 commits into
provoke210 wants to merge 2 commits into
Conversation
Build one py3-none Metal wheel and download its artifact by name so two macOS jobs cannot write different wheels to the same release path. Verify the wheel ZIP before artifact upload and before release. Assisted-by: OpenAI Codex Signed-off-by: Haozhe Jiang <162801044+provoke210@users.noreply.github.com>
Assisted-by: OpenAI Codex Signed-off-by: Haozhe Jiang <162801044+provoke210@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Metal workflow built the same
py3-none-macosx_11_0_arm64.whlfilename on both macos-14 and macos-15, then downloaded both artifacts into onedist2directory withmerge-multiple: true. The published v0.3.36 Metal wheel has a broken ZIP entry (lib/cmake/ggml/ggml-config.cmake), while both original artifacts from run 36821195139 pass ZIP CRC validation. Their SHA-256 prefixes are37c2f21e(macos-14) and9b459c85(macos-15), but the released wheel's is64c98e6a. The released file starts with 327,369 bytes identical to the macos-15 artifact and ends with 671,538 bytes identical to the macos-14 artifact. This byte-level mix shows the collision damaged the wheel during artifact merging, after each build completed.Change
Build one Metal wheel on macos-14 using the package's
py3-nonewheel setting. Download that artifact by name, and verify every ZIP member both before artifact upload and before publishing the release. Require exactly one wheel at each stage.Validation
py3-nonearchive passes the new validator.git diff --checkpasses.Refs #2352.
AI assistance
Assisted by OpenAI Codex for root-cause analysis, implementation, local validation, and this PR description.