-
Notifications
You must be signed in to change notification settings - Fork 3
add reaction delete summary test #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File CoverageNo changed files found. |
| }, | ||
| { timeout: 30_000 }, | ||
| ); | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be a good idea to clear the found array here?
| }); | ||
|
|
||
| // Check fourth summary (after deleting ❤️ - should be empty or not have these reactions) | ||
| const fourthSummary = found.findLast((e) => e.summary.messageSerial === message1.serial); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the third one is not at index 2 (third in list), you'll find the third one here.
Would it be better to just findIndex the third one, and get the other index for the fourth one?
We're talking about indexes 2 and 3 for those checks, or 0 and 1 if you clear the found array.
I guess the same logic for finding the summaries in the list can be done for the first two as well?
|
This will work now, but I'm a bit worried about testing individual summaries after sending a few annotations, because the idea with summaries is that we won't get one summary per annotation soon-ish (after we do rollups, or even now if we batch-publish the annotations). |
No description provided.