(2023-05-02, temporary) Run PR #1707 in loop #1708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can see things like library logs, or any additional logging we might add to help debug a test case.
… GitHub job running time limit I’m trying to understand the reason that the upload artifacts step is hung here [1], and I’m wondering if it’s because the job execution limit had already been reached by my script. [1] https://github.com/ably/ably-cocoa/runs/5979297645?check_suite_focus=true
To help with understanding issue described in 7260cda.
I’m hoping this will reduce the upload time (more by reducing the number of files than the size).
This lets us choose the length and parallelism of our test runs.
In a subsequent commit, I’m going to want each test case to be able to pass parameters to the setup code.
Motivation as in 7fd30c4.
This is currently being passed to - uniqueChannelName(…) — to include the execution ID in the channel name - createUserQueue(…) — to include the execution ID in the queue label - commonAppSetup(…) — to include the execution ID in the channelNamePrefix and the intention is that it will be a unique identifier eventually used to link together everything to do with a given test method execution — e.g. for tagging log messages, labelling dispatch queues etc.
Just a refactor. TODO I should be splitting this up into a commit per method, to make it clearer
we're assuming that they want these to be the same thing, not obvious why TODO change this so that everything takes an explicit queue parameter, and then go through and find all of the tests where AblyTests.queue is referred to multiple times and turn them into a variable
Motivation as in cd80ddb.
This serves as a handy way of knowing when the corresponding dispatch queue is being created and destroyed, and hence finding out whether we’re leaking dispatch queues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing #1707, and also want to gather logs to find out about leaked dispatch queues. Results here.