Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.2.50 #1070

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Release/1.2.50 #1070

merged 2 commits into from
Feb 25, 2025

Conversation

ttypic
Copy link
Contributor

@ttypic ttypic commented Feb 25, 2025

Closed issues:

  • Warning on Android Proguard #1067

Implemented enhancements:

  • Added internal Kotlin Wrapper for the SDK

Summary by CodeRabbit

  • Documentation
    • Updated release notes, guides, and dependency instructions to reflect version 1.2.50.
  • Bug Fixes
    • Resolved an Android compatibility warning.
  • New Features
    • Introduced an enhancement that improves SDK integration.
  • Chores
    • Updated project version and dependency references to version 1.2.50.
  • Tests
    • Adjusted version verifications in testing to align with the new release.

@ttypic ttypic requested review from sacOO7 and umair-ably February 25, 2025 10:37
Copy link

coderabbitai bot commented Feb 25, 2025

Walkthrough

This update increments the project version from 1.2.49 to 1.2.50. Documentation files (CHANGELOG.md, README.md, CONTRIBUTING.md) now reference the new version through updated dependency declarations, version properties, and changelog entries. The changelog logs a closed issue regarding an Android Proguard warning and documents an internal Kotlin Wrapper enhancement. In addition, the test method in RealtimeHttpHeaderTest.java has been updated to expect the new version in its agent string.

Changes

Files Change Summary
CHANGELOG.md Added a new version section [1.2.50] with links to the specific and full changelogs, recorded a closed issue (#1067), and noted the internal Kotlin Wrapper enhancement.
CONTRIBUTING.md Updated the dependency declaration from ably-android-1.2.49.aar to ably-android-1.2.50.aar.
README.md Updated dependency versions for ably-java, ably-android, and network-client-okhttp from 1.2.49 to 1.2.50.
gradle.properties Changed VERSION_NAME from 1.2.49 to 1.2.50.
lib/.../RealtimeHttpHeaderTest.java Modified the expected agent string in the test from "ably-java/1.2.49" to "ably-java/1.2.50".

Possibly related PRs

  • Release/1.2.45 #1047 – Addresses similar changes in CHANGELOG.md and test updates reflecting a version increment.
  • Release/1.2.42 #1030 – Modifies the expected agent string in RealtimeHttpHeaderTest.java to align with version updates.
  • Release/1.2.49 #1062 – Involves dependency and version number updates, closely related to the versioning changes in this PR.

Suggested reviewers

  • sacOO7

Poem

I hopped through lines of code so neat,
Updating versions with every beat,
From CHANGELOG tales to tests that sing,
With Kotlin magic in the ring,
A joyful leap to version 1.2.50 – oh what a treat!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8d9f17 and 90b7fa1.

📒 Files selected for processing (5)
  • CHANGELOG.md (1 hunks)
  • CONTRIBUTING.md (1 hunks)
  • README.md (2 hunks)
  • gradle.properties (1 hunks)
  • lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • gradle.properties
  • CONTRIBUTING.md
  • README.md
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: check-rest-okhttp
  • GitHub Check: check (29)
  • GitHub Check: check (24)
  • GitHub Check: check-rest
  • GitHub Check: check-realtime-okhttp
  • GitHub Check: check (21)
  • GitHub Check: check (19)
  • GitHub Check: check-realtime
🔇 Additional comments (1)
lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1)

91-91: Version update correctly applied in test expectation.

The expected agent string has been updated from version 1.2.49 to 1.2.50, which correctly aligns with the version increment mentioned in the PR objectives. This ensures the test accurately validates the agent string after the version update.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ttypic ttypic merged commit 971ce85 into main Feb 25, 2025
12 checks passed
@ttypic ttypic deleted the release/1.2.50 branch February 25, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants