Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/no connection serial #983

Merged
merged 81 commits into from
Feb 26, 2024
Merged

Feature/no connection serial #983

merged 81 commits into from
Feb 26, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Dec 1, 2023

Fixed #974
Fixed #846
Fixed #976

sacOO7 added 26 commits November 24, 2023 23:58
@sacOO7
Implemented connectionRecoveryKey
fe52c3f
@sacOO7
Renamed file to recoverykeycontext
c3e7576
@sacOO7
Added a test to check for encoded recovery key
2549547
@sacOO7
Added test for encoding and decoding recovery key
c767de2
@sacOO7
Added channel serial to channel properties
25b9cdc
@sacOO7
Added method to set channelSerials from recover option
a7938e3
@sacOO7
Added method for getting channel serials to Channels class
2a8bbbd
@sacOO7
Marked recoveryKey field as deprecated
6461967
@sacOO7
Merge branch 'feature/no-connection-serial' into feature/no-connectio…
1897227 
…n-serial-recovery-key
@sacOO7
Added explicit method for creating a recovery key
180d68f
@sacOO7
Simplified recoveryKeyContext class
1509938
@sacOO7
Setting recovery key and serials from clientOption
169392e
@sacOO7
Refactored recoverykey to use createRecoveryKey method
c6af891
@sacOO7
Removed all connection serial references from the code
e7dc410
@sacOO7
Added explicit null checks for recoveryKey
130305b
@sacOO7
Implemented channel serial for message reeived
3c04523
@sacOO7
Added missing implementation for channel detach when attached msg rec…
0efffdf 
…eived
@sacOO7
Updated code to send explicit detach message when attached received in
3ebeed7 
detach state
@sacOO7
Created internal presencemap for internal presence
21661c4
@sacOO7
Clearing channel serial as per RTP5a1
d465489
@sacOO7
resetting message serial on failed connection resume or recover
b42ff87
@sacOO7
Fixed AblyRealtime as class imports
5b8ab5e
@sacOO7
refactored ably protocol and agent headers in accordance with version id
bb42aea
@sacOO7
Updated test for protocol version
5b8e5b7
@sacOO7
Added suspended state as per RTL13a for server initiated detached
232d87b
@sacOO7
Merge pull request #980 from ably/feature/no-connection-serial-recove…
47862f4 
…ry-key

Feature/no connection serial recovery key
@github-actions github-actions bot temporarily deployed to staging/pull/983/features December 1, 2023 15:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/983/javadoc December 1, 2023 15:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/983/features December 4, 2023 11:13 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/983/features February 6, 2024 13:31 Inactive
@sacOO7 sacOO7 requested a review from lmars February 6, 2024 13:31
@github-actions github-actions bot temporarily deployed to staging/pull/983/javadoc February 6, 2024 13:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/983/features February 6, 2024 20:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/983/javadoc February 6, 2024 20:43 Inactive
@sacOO7 sacOO7 force-pushed the feature/no-connection-serial branch from b6210aa to c0fd61f Compare February 6, 2024 20:45
@github-actions github-actions bot temporarily deployed to staging/pull/983/features February 6, 2024 20:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/983/javadoc February 6, 2024 20:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/983/features February 7, 2024 11:47 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/983/javadoc February 7, 2024 11:48 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review February 7, 2024 12:17
@sacOO7 sacOO7 requested a review from paddybyers February 7, 2024 12:19
SimonWoolf
SimonWoolf approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@SimonWoolf SimonWoolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this a fairly cursory lookthrough since all the individual parts should already have been reviewed (and with the caveat that I'm not very familiar with the ably-java codebase), but can't see anything obviously wrong 👍

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Feb 12, 2024

Giving this a fairly cursory lookthrough since all the individual parts should already have been reviewed (and with the caveat that I'm not very familiar with the ably-java codebase), but can't see anything obviously wrong 👍

Thanks!

ttypic
ttypic approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sacOO7 sacOO7 merged commit 00ee72f into main Feb 26, 2024
8 of 9 checks passed
@sacOO7 sacOO7 deleted the feature/no-connection-serial branch February 26, 2024 13:28
@sacOO7 sacOO7 mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonWoolf SimonWoolf SimonWoolf approved these changes

@ttypic ttypic ttypic approved these changes

@AndyTWF AndyTWF Awaiting requested review from AndyTWF

@lmars lmars Awaiting requested review from lmars

@paddybyers paddybyers Awaiting requested review from paddybyers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@sacOO7 @SimonWoolf @ttypic