-
Notifications
You must be signed in to change notification settings - Fork 45
Edu 2071 remove the general section of faqs #2824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edu 2071 remove the general section of faqs #2824
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -0,0 +1,138 @@ | |||
| --- | |||
| title: Terms of Service | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's correct to repeat these from the website, as we're just duplicating the content. If we think it's important to still reference them (maybe look at the relative popularity of the FAQ) then it should be an FAQ that links out to the website.
You could also test 'Ask Ably' and see what that currently picks up (I suspect it will just land them on the original terms of serivce, rather than going via the FAQs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where have the FAQs come from in this fixup? I don't think we should be trying to parse or shorten these at all.
Let's add the question to the pricing FAQ and link out.
2e92099 to
d6400bb
Compare
m-hulbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,138 @@ | |||
| --- | |||
| title: Terms of Service | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where have the FAQs come from in this fixup? I don't think we should be trying to parse or shorten these at all.
Let's add the question to the pricing FAQ and link out.
|
@m-hulbert Please see the update in the updated commit comments in the PR description at the top for -> Addresses reviewer feedback |
af7f8f8 to
60ed50f
Compare
60ed50f to
c0d2cb6
Compare
This PR removes the general FAQ section and adds comprehensive documentation improvements across multiple areas of the platform:
Can I use Ably for audio and video streaming or images and file sharing?
How can I set up different environments in Ably?
Is there a limit to the length of the ClientId or Channel name?
How can I subscribe to messages using REST only SDKs?
CSP Rejection to internet-up.ably-realtime.com/is-the-internet-up.txt
Are the Message and Data Transfer Limits Enforced Separately?
Should I reduce the REST publish timeout?
Do you have a terms of service?
How can I alert a user to subscribe to a channel?
Addresses reviewer feedback
Redirects: General FAQ
FAQ: https://faqs.ably.com/general
Jira: EDU-2071