Skip to content

Conversation

@coderabbitai
Copy link

coderabbitai bot commented Sep 11, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch EDU-2071-remove-the-general-section-of-fa-qs

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@franrob-projects franrob-projects changed the title Edu 2071 remove the general section of fa qs Edu 2071 remove the general section of faqs Sep 11, 2025
@franrob-projects franrob-projects added the review-app Create a Heroku review app label Sep 11, 2025
@ably-ci ably-ci temporarily deployed to ably-docs-edu-2071-remo-krvjxm September 11, 2025 14:09 Inactive
@franrob-projects franrob-projects marked this pull request as ready for review September 11, 2025 14:09
@@ -0,0 +1,138 @@
---
title: Terms of Service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's correct to repeat these from the website, as we're just duplicating the content. If we think it's important to still reference them (maybe look at the relative popularity of the FAQ) then it should be an FAQ that links out to the website.

You could also test 'Ask Ably' and see what that currently picks up (I suspect it will just land them on the original terms of serivce, rather than going via the FAQs).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where have the FAQs come from in this fixup? I don't think we should be trying to parse or shorten these at all.

Let's add the question to the pricing FAQ and link out.

@franrob-projects franrob-projects force-pushed the EDU-2071-remove-the-general-section-of-fa-qs branch from 2e92099 to d6400bb Compare September 19, 2025 11:34
Copy link
Contributor

@m-hulbert m-hulbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think this needs to be retained in the short term.
  • I think this is covered to some extent, but we should also be covering some of this info on the history page and linking back to the explanation to CGO.

@@ -0,0 +1,138 @@
---
title: Terms of Service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where have the FAQs come from in this fixup? I don't think we should be trying to parse or shorten these at all.

Let's add the question to the pricing FAQ and link out.

@franrob-projects
Copy link
Contributor Author

franrob-projects commented Oct 1, 2025

@m-hulbert Please see the update in the updated commit comments in the PR description at the top for -> Addresses reviewer feedback

@franrob-projects franrob-projects force-pushed the EDU-2071-remove-the-general-section-of-fa-qs branch from af7f8f8 to 60ed50f Compare November 18, 2025 14:41
@franrob-projects franrob-projects force-pushed the EDU-2071-remove-the-general-section-of-fa-qs branch from 60ed50f to c0d2cb6 Compare November 18, 2025 14:52
@franrob-projects franrob-projects merged commit d930f21 into main Nov 20, 2025
6 checks passed
@franrob-projects franrob-projects deleted the EDU-2071-remove-the-general-section-of-fa-qs branch November 20, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

5 participants