Skip to content

Conversation

keshav-space
Copy link
Member

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... See my review comments. Please keep segments and canonical_segments as tuples, e.g. the new property should return a tuple() not a generator.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@pombredanne pombredanne requested a review from TG1999 October 20, 2022 13:57
Signed-off-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Keshav Priyadarshi <[email protected]>
@TG1999 TG1999 merged commit 205da7e into aboutcode-org:main Apr 11, 2023
@keshav-space keshav-space deleted the refactor_gem branch April 11, 2023 19:02
keshav-space pushed a commit that referenced this pull request Aug 30, 2023
Update the following actions:

* actions/checkout
* actions/setup-python

Reference: aboutcode-org/skeleton#75
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
keshav-space pushed a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants