This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
MG-211 - Update time series bar chart fo fetch data from back-end #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
MG-211_time_series_bar
branch
from
02c677a to
9555d77
Compare
felixgateru
force-pushed
the
MG-211_time_series_bar
branch
from
b1c4bac to
fa93291
Compare
dborovcanin
force-pushed
the
MG-211_time_series_bar
branch
from
fa93291 to
f367626
Compare
ianmuchyri
suggested changes
Mar 13, 2024
ui/web/static/js/charts.js
Outdated
Comment on lines
248
to
249
| from: ${this.chartData.startTime / 1000}, | ||
| to: ${this.chartData.stopTime / 1000}, |
There was a problem hiding this comment.
Suggested change
| from: ${this.chartData.startTime / 1000}, | |
| to: ${this.chartData.stopTime / 1000}, | |
| from: ${this.chartData.startTime}, | |
| to: ${this.chartData.stopTime}, |
felixgateru
force-pushed
the
MG-211_time_series_bar
branch
3 times, most recently
from
90fb2ea to
b27f358
Compare
ianmuchyri
suggested changes
Mar 14, 2024
ui/web/static/js/charts.js
Outdated
| throw new Error("HTTP request failed with status: " + response.status); | ||
| } | ||
| const data = await response.json(); | ||
| console.log(data); |
|
Also make it such that aggregation is not compulsory. Check how it was changed in the line chart. Aggregation is not compulsory, but if a user selects aggregation, then they have to select interval |
ianmuchyri
suggested changes
Mar 14, 2024
ui/web/static/js/charts.js
Outdated
|
|
||
| async function getData(barChart, chartData) { | ||
| try { | ||
| const apiEndpoint = "/data?channel=" + chartData.channel + |
ianmuchyri
suggested changes
Mar 14, 2024
| } | ||
| } | ||
| toggleUpdateInterval(); | ||
| aggregationTypeInput.addEventListener("change", toggleUpdateInterval); |
There was a problem hiding this comment.
toggleUpdateInterval();
aggregationTypeInput.addEventListener("change", toggleUpdateInterval);
what is the difference here. Since the function has been called by default in the first instance
ianmuchyri
suggested changes
Mar 15, 2024
| chartData[pair[0]] = pair[1]; | ||
| if (pair[0] === "startTime" || pair[0] === "stopTime") { | ||
| const inputDate = new Date(pair[1]); | ||
| chartData[pair[0]] = inputDate.getTime() * 1e6; |
There was a problem hiding this comment.
r
Suggested change
| chartData[pair[0]] = inputDate.getTime() * 1e6; | |
| chartData[pair[0]] = inputDate.getTime() ; |
felixgateru
force-pushed
the
MG-211_time_series_bar
branch
from
48cf431 to
2ab8736
Compare
ianmuchyri
suggested changes
Mar 18, 2024
| @@ -226,7 +244,12 @@ <h5 class="modal-title" id="barChartModalLabel">Time Series Bar Chart</h5> | |||
| let chartData = {}; | |||
| let formData = new FormData(form); | |||
| for (var pair of formData.entries()) { | |||
There was a problem hiding this comment.
Suggested change
| for (var pair of formData.entries()) { | |
| for (let [name, value] of formData) { |
dborovcanin
approved these changes
Mar 18, 2024
felixgateru
force-pushed
the
MG-211_time_series_bar
branch
2 times, most recently
from
11d09c7 to
4ddff5e
Compare
ianmuchyri
suggested changes
Mar 19, 2024
| @@ -216,31 +216,86 @@ class TimeSeriesBarChart extends Echart { | |||
| }, | |||
| xAxis: { | |||
There was a problem hiding this comment.
Suggested change
| xAxis: { | |
| tooltip: { | |
| trigger: 'axis' | |
| }, | |
| xAxis: { |
felixgateru
force-pushed
the
MG-211_time_series_bar
branch
from
4ddff5e to
2d275cf
Compare
Signed-off-by: felix.gateru <[email protected]>
Signed-off-by: felix.gateru <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
force-pushed
the
MG-211_time_series_bar
branch
from
2d275cf to
20939d2
Compare
dborovcanin
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Populate the time series bar chart with data from the back-end
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes