-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MF-1065 - Create commands service #1457
Conversation
Signed-off-by: fbugarski <[email protected]>
Signed-off-by: fbugarski <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1457 +/- ##
==========================================
- Coverage 70.92% 70.90% -0.03%
==========================================
Files 123 123
Lines 9564 9564
==========================================
- Hits 6783 6781 -2
- Misses 2254 2256 +2
Partials 527 527
Continue to review full report at Codecov.
|
Signed-off-by: fbugarski <[email protected]>
Signed-off-by: fbugarski <[email protected]>
Signed-off-by: fbugarski <[email protected]>
@@ -5,7 +5,7 @@ MF_DOCKER_IMAGE_NAME_PREFIX ?= mainflux | |||
BUILD_DIR = build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not important for this PR but it would be nice to add here MF_RELEASE ?= latest
and then replace
--tag=$(MF_DOCKER_IMAGE_NAME_PREFIX)/$(svc):latest\
with
--tag=$(MF_DOCKER_IMAGE_NAME_PREFIX)/$(svc):$(MF_RELEASE) \
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mteodor interesting - please open a new issue for this and send the PR
Signed-off-by: fbugarski <[email protected]>
Signed-off-by: fbugarski <[email protected]>
commands/api/requests.go
Outdated
Command string `json:"command"` | ||
Name string `josn:"name"` | ||
ChannelID string `json:"channel_id"` | ||
ExecuteTime time.Time `json:"execute_time"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - Metadata is missing here.
Signed-off-by: fbugarski <[email protected]>
Signed-off-by: fbugarski <[email protected]>
Signed-off-by: fbugarski <[email protected]>
Signed-off-by: fbugarski <[email protected]>
While the idea is still valid, this PR has been stale for a while and it isn't easy to continue to work on it before huge refactoring, at which point it's simpler to rewrite everything. We'll probably use a different approach with workflow pipelines that are on the roadmap instead. I'll close it but keep the issue open and we can eventually reopen it if we decide to continue this work. |
Signed-off-by: fbugarski [email protected]
Pull request title should be
MF-XXX - description
orNOISSUE - description
where XXX is ID of issue that this PR relate to.Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
Resolves Create a Commands Service #1065