BUG: GitHub Actions and artifact upload, broken doc links

[jklenzing]

Description

The action upload-artifact@v3 was deprecated earlier this year, breaking the GitHub Actions workflow. According to this, artifact names are now immutable, meaning each must be tagged with a version when uploaded.

After discussion with @aburrell, the upload here was a test to generate a wheel, but the end product was unused. This PR removes the lines from the workflow rather than updating.

Also identified a broken link in the documentation to a publication no longer hosted by NOAA. Options for fixing this discussed below.

Fixes #153

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Inspection of GitHub Actions workflows. Tests now run successfully.

Test Configuration

• Operating system: mac, ubuntu, windows
• Python version number: 3.9, 3.10, 3.11, 3.12
• Compiler with version number: gfortran 12.2.0
• Relevant local setup details: GitHub Actions

Checklist

• Make sure you are merging into the develop (not main) branch
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• Add a note to Changelog.rst, summarising the changes
• Add yourself to AUTHORS.rst and .zenodo.json

[jklenzing]

@aburell, I have confirmed that the Snay and Soler paper in the docs is broken at NOAA, and I cannot find a version hosted in the NGS website. Google Scholar lists a number of other places it is hosted. The Purdue link is just part 1, the others are parts 1-4 combined. Options include:

• https://engineering.purdue.edu/~bethel/Reference-Systems-Part-1.pdf
• https://www.academia.edu/download/7616146/reference-systems.pdf
• https://prltap.org/eng/wp-content/uploads/2016/09/Modern-Terrestrial-Reference-Systems-Part-1-to-Part-4.pdf
• https://www.researchgate.net/profile/Richard-Snay/publication/267509222_Modern_Terrestrial_Reference_Systems_Part_1/links/5e1619ada6fdcc2837631495/Modern-Terrestrial-Reference-Systems-Part-1.pdf

When clicking on the researchgate link, I get a "confirm you are human" page for a bit, so this might not pass the link check.

[aburrell]

How about the PRL Tap one?

[jklenzing]

Fixed. That passes the link check.

[jklenzing]

Also noting that my editor automatically removes trailing whitespace.

[coveralls]

Pull Request Test Coverage Report for Build 13997531060

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 99.701%

---

Totals
Change from base Build 12657320651:	0.0%
Covered Lines:	999
Relevant Lines:	1002

---

💛 - Coveralls

[ljlamarche]

I looked this over and don't see anything concerning. This all looks like it's to do with GH Actions, so I don't think there's any thing for me to test further?

[aburrell]

@ljlamarche that's correct. I mostly just wanted to make sure you weren't currently using the CI wheels for anything. If I remember correctly, they never ended up being useful.

[ljlamarche]

Nope, I don't believe I've ever actually ended up using those (to be honest, I always found it a bit confusing). Totally fine with me if they go away.