Conversation
Added the Starkov boundary model to a new model file under boundaries.
Began adjusting the boundary classes to accept model input, starting with OCBoundary by: - adjusting inputs for `instrument`, `stime`, `rfunc`, and `rfunc_kwargs` to permit initialization with a mathematical model function, - moving hidden methods to the same section of the class, - moving the logic reformatting the `rfunc` and `rfunc_kwargs` input into a new hidden method, - added more logic to reform `rfunc_kwargs` inputs for easier model input specification, - created a method for initializing the data to be ready for model input, and - adjusted the `load` method to call hidden methods for loading based on whether the boundaries are provided by an instrument or a model.
Added a summary of the current changes to the changelog.
Fixed log call to use log10 instead of ln.
Updated all boundary classes to take model input. Adjusted class string output to be shorter for instances with a lot of different geomagnetic indices in the model kwarg inputs.
Added a citation for the Starkov model.
Added a model example to the documentation.
Added a model initialization example to the documentation.
Added the ellipses to the expected example output.
Added a section to hold the boundary models in the docs.
Ensure all co-latitudes have a realistic lower limit.
Added unit tests for the Starkov functions.
Added test for the different boundary classes with model initialization and loading.
Fixes ellipses to only appear of there are records that are not shown in the printed representation.
Updated the class display to include ellipses.
Fixed the documentation typing for python text.
Added members section to automodule.
Fixed the use of references in the models docstring.
Owner
Author
|
Failed tests are addressed in #152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #124 by adding an empirical model for the OCB, and two different equatorward boundaries based off of northern hemisphere all-sky imager data. This is an older model, but creates a framework for adding newer auroral boundary models.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit tests, integration tests, and examples in the documentation.
This yeilds:
Test Configuration
Checklist:
develop(notmain) branchChangelog.rst, summarising the changesAUTHORS.rstand.zenodo.json