Enhance NotificationService's Notification Listener with robust message acknowledgment and DLQ support #904
+63
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the NotificationService to implement a more robust message handling mechanism that better emulates standard message acknowledgment patterns (ACK/NACK). A typical use case is for notifications that process with error should be retried until the maximum number of reads are reached. Once maximum number of reads are reached, Amazon SQS will automatically move the message to a dead letter queue if configured.
Key Changes:
New Interface: Added IMessageReceiverWithResult, which allows consumers to return a boolean result for each message.
Implementation: Implemented the Adapter Pattern and Method Overloading in NotificationService to safely handle different receiver types without runtime type checking.
Backward Compatibility: Existing functionality remains exactly the same. Consumers using the original IMessageReceiver will experience no changes in behavior.