-
Notifications
You must be signed in to change notification settings - Fork 136
Add cuda api tracer tool to accel-sim framework #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
One thing I'm going to complain about is identifying data types. Is this the only way? It will instantly fail if an application uses some custom data type. |
Yeah that is fair. I guess there are two ways to do this:
But ultimately still have to perform some checks on whether the argument is a pointer or not, which could only be confirmed by checking the function signature? |
Can you add an else if block at the end and just |
…mework into cuda_api_tracer
For the data type identification, we can use the PTX parser in gpgpu-sim to parse it, though it is somewhat hacky. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@William-An - this change looks great.
Do we have a test that tests the tracer?
Also a minor comment about some of the commented out code.
} | ||
|
||
|
||
// TODO: Cannot use this until next issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enable this now?
We don't have any tests for it now. I will add one after I update the NVBit version. Also, I will probably need to run this tracer with not just a toy vector add example. |
Add CUDA runtime API tracer. Able to track:
int
,float
,double
, and their 1D pointers)