Fix remaining CI issues - #172
Merged
Merged
Conversation
Signed-off-by: Lukas Jünger <lukas@mwa.re>
Signed-off-by: Lukas Jünger <lukas@mwa.re>
Signed-off-by: Lukas Jünger <lukas@mwa.re>
maehne
approved these changes
Aug 25, 2026
lmailletcontoz
merged commit Aug 25, 2026
1e93ad9
into
accellera-official:main
87 of 89 checks passed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily fixes the CI issue on MacOS, which seems to be some sort of race condition with make.
I switched to ninja build on MacOS, which is preferable anyways.
This PR also incoporates changes proposed in these two:
I would propose to merge 159 and 171 before this one.
With this CI is fully passing on my fork :)