[module_manager] Add Translations to Module_Manager #10002
+147
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Language: Javascript
SKADE2303
added
Event: GSOC
driusan
reviewed
Sep 9, 2025
Makefile
Outdated
| msgfmt -o modules/brainbrowser/locale/ja/LC_MESSAGES/brainbrowser.mo modules/brainbrowser/locale/ja/LC_MESSAGES/brainbrowser.po | ||
| msgfmt -o modules/bvl_feedback/locale/ja/LC_MESSAGES/bvl_feedback.mo modules/bvl_feedback/locale/ja/LC_MESSAGES/bvl_feedback.po | ||
| msgfmt -o modules/candidate_list/locale/hi/LC_MESSAGES/candidate_list.mo modules/candidate_list/locale/hi/LC_MESSAGES/candidate_list.po | ||
| npx i18next-conv -l hi -s modules/candidate_list/locale/hi/LC_MESSAGES/candidate_list.po -t modules/candidate_list/locale/hi/LC_MESSAGES/candidate_list.json |
There was a problem hiding this comment.
What's the difference between this and line 76/77?
driusan
reviewed
Sep 9, 2025
| text: 'Updated ' + name + ' status! ' + | ||
| 'To apply changes the interface must be reloaded. Proceed?', | ||
| title: t('Success!', {ns: 'module_manager'}), | ||
| text: t('Updated', {ns: 'module_manager'}) + |
There was a problem hiding this comment.
String concatenation is not the right way to handle variables because the location of the variable (name) in the sentence changes between languages.
It looks like i18next supports format strings that should be used instead: https://www.i18next.com/translation-function/formatting
racostas
added
the
State: Needs work
added 2 commits
September 19, 2025 08:23
SKADE2303
removed
the
State: Needs work
racostas
requested changes
Sep 23, 2025
racostas
added
the
State: Needs work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for translating the module module_manager to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)