[my_preferences] Translate to my_preferences module #10015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SKADE2303
added
Module: my_preferences
racostas
requested changes
Sep 16, 2025
There was a problem hiding this comment.
Hi @SKADE2303 , as requested in #10009
Save and Reset should be in loris.po ns not in the module itself since this two worlds are used all across the LORIS system. Thank you.
racostas
added
the
State: Needs work
|
There are also missing translations |
SKADE2303
force-pushed
the
TranslateMyPreferences
branch
from
2509634 to
41d56c4
Compare
|
@SKADE2303 , automatic tests still failing here. |
racostas
added
the
State: Needs rebase
|
Conflicts need to be resolved. Needs rebase. Also the test that are failing here does are related to this PR. |
SKADE2303
force-pushed
the
TranslateMyPreferences
branch
from
49c7b3a to
c0e0aa5
Compare
|
Is this one ready to be re-reviewed ? |
racostas
requested changes
Sep 30, 2025
SKADE2303
force-pushed
the
TranslateMyPreferences
branch
2 times, most recently
from
8c714cc to
4f7e6d4
Compare
SKADE2303
force-pushed
the
TranslateMyPreferences
branch
from
0e4263c to
5a04f4f
Compare
|
Test still failing here. Please re-launch / fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is responsible for translating the module my_preferences to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.
Testing instructions (if applicable)